[SPIRV] Enable switch statement tests#1393
Draft
farzonl wants to merge 2 commits into
Draft
Conversation
This change was not really a matrix spir-v bug, but it did disable our swizzle testing. Now that llvm/llvm-project#209859 has merged issue llvm/llvm-project#209310 is fixed and we can re-enable these matrix swizzle tests for spir-v via llvm\clang.
Icohedron
approved these changes
Jul 22, 2026
Icohedron
left a comment
Icohedron
left a comment
Contributor
There was a problem hiding this comment.
LGTM assuming the tests do pass
kmpeng
approved these changes
Jul 22, 2026
farzonl
marked this pull request as draft
July 23, 2026 00:01
Member
Author
|
I need one more pr to merge before we re enable these tests. Moving to draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change was not really a matrix spir-v bug, but it did disable our swizzle testing. Now that llvm/llvm-project#209859 has merged issue llvm/llvm-project#209310 is fixed and we can re-enable these matrix swizzle tests for spir-v via llvm\clang.