[Resource] Add tests for resource access in control flow#1374
Open
inbelic wants to merge 11 commits into
Open
Conversation
inbelic
added
test-all
inbelic
force-pushed
the
inbelic/resource-access
branch
from
July 15, 2026 23:38
8f6eb59 to
176e283
Compare
inbelic
marked this pull request as ready for review
July 21, 2026 23:18
alsepkow
reviewed
Jul 21, 2026
| #--- source.hlsl | ||
|
|
||
| // Dynamic resource: Bufs[I] is indexed by the loop induction variable, so each | ||
| // iteration selects a different resource. LICM cannot hoist the load, and the |
Collaborator
There was a problem hiding this comment.
Co-pilot suggested the filename should be 'licm-no-hoist-load-array.test'.
I agree, Thanks co-pilot!
bob80905
reviewed
Jul 22, 2026
|
|
||
| Results: | ||
| - Result: BufOut | ||
| Rule: BufferFloatULP |
Contributor
There was a problem hiding this comment.
Could this be an exact match instead?
Contributor
Author
There was a problem hiding this comment.
Good idea, changed the type to uint to make it easier and to match exactly
| RWStructuredBuffer<float> LocalBuf = Bufs[0]; | ||
|
|
||
| if ((TID & 1u) == Condition) | ||
| LocalBuf = Bufs[1]; |
Contributor
There was a problem hiding this comment.
Might this be a scenario where we use NonUniformResourceIndex ?
bob80905
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds test coverage for resource access patterns that are potential optimizations in modern llvm. These optimizations can create illegal looking resource accesses in clang. DXC does not represent resource access through a regular store/load and will perform any such optimizations.
Optimizations considered:
GVNsink of load/storeSimplifyCFGsink of load/storeInstCombinephi sink of loadLICMloop invariant sinkThese are considered for [non-]dynamic resources and resources that result in a gep of a struct member.
Assisted by: Claude Opus 4.8