load devices lazily - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app fetched every device file at startup. That is fine for three devices and impossible for the 400 coming from the MIDI Guide dataset, so devices are now fetched one at a time, on selection.
devices/index.jsonentries become{ file, name, manufacturer }instead of bare filenames, which is enough to build the picker without touching a device file.validate-devices.mjschecks that duplicated metadata stays in step with the device it describes.loadShippedDevicessplits intoloadDeviceIndexandloadDevice. Selection is async and carries a token, so a slow fetch can't overwrite a newer selection, and the device select is keyed by filename rather than array position.The picker is now two dependent selects: manufacturer, then model.