-
Notifications
You must be signed in to change notification settings - Fork 276
add e2e signalling tests #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukasIO
wants to merge
9
commits into
main
Choose a base branch
from
lukas/signal-e2e
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add e2e signalling tests #1998
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f3a1c57
add e2e signalling tests
lukasIO 7084276
run action for testing
lukasIO d0e13a6
remove action test branch
lukasIO ec91f64
lint
lukasIO e82f68e
cleaner unref handling
lukasIO 5613db8
clean up deps
lukasIO 597b077
cleanup
lukasIO 8c66b0b
use canonical TS version
lukasIO 3e9d4a1
fix config
lukasIO File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| name: E2E | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| e2e: | ||
| name: Signal e2e (browser / ubuntu) | ||
| runs-on: ubuntu-latest | ||
|
|
||
| services: | ||
| testserver: | ||
| image: livekit/test-server:latest | ||
| ports: | ||
| - 9999:9999 | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
|
|
||
| - uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320 # v4.4.0 | ||
|
|
||
| - name: Use Node.js 24 | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version: 24 | ||
| cache: 'pnpm' | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install | ||
|
|
||
| - name: Cache Playwright browsers | ||
| uses: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830 # v4.3.0 | ||
| with: | ||
| path: ~/.cache/ms-playwright | ||
| key: ${{ runner.os }}-playwright-${{ hashFiles('pnpm-lock.yaml') }} | ||
|
|
||
| - name: Install Playwright Chromium | ||
| run: pnpm exec playwright install --with-deps chromium | ||
|
|
||
| - name: Run signal e2e tests | ||
| run: pnpm test:e2e 2>&1 | tee e2e.log | ||
| env: | ||
| # Connect to the test-server service above (validate + WS on 9999). | ||
| LK_TEST_SERVER_URL: ws://127.0.0.1:9999 | ||
|
|
||
| - name: Collect test-server logs | ||
| if: failure() | ||
| run: docker logs ${{ job.services.testserver.id }} > test-server.log 2>&1 || true | ||
|
|
||
| - name: Upload logs | ||
| if: failure() | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
| with: | ||
| name: e2e-logs | ||
| path: | | ||
| e2e.log | ||
| test-server.log | ||
| retention-days: 7 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Just curious, how stable have these been so far in ci?