chore(deps): require stable z-engine releases instead of dev branches - #14
Merged
Merged
Conversation
z-engine now ships stable tags for both supported PHP minors (8.4.2 on the 8.4 line, 8.5.0 on the 8.5 line), so the development-branch constraint is no longer needed. - require "lisachenko/z-engine": "~8.4.2 || ~8.5.0" — one stable release line per supported PHP minor. The tilde admits patch releases inside a line but never the next minor line, which would be built for a PHP this package does not claim to support; each z-engine tag also declares its own ~8.4.0/~8.5.0 platform requirement, so only one line can ever satisfy a given runtime. - drop the root "minimum-stability": "dev" / "prefer-stable": true pair — nothing in require is a development branch any more, so installing this package no longer forces development stability on a consumer's project. - README: describe the resolved z-engine line as a release line. The CI "lowest" leg now resolves real tags (8.4.2 / 8.5.0) rather than a branch tip, so the floor it tests is a version that actually exists. Verified on both minors: PHP 8.4.19 resolves z-engine 8.4.2 and PHP 8.5.9 resolves 8.5.0, 8/8 .phpt tests pass on each. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013foRd1XwLwqjUSkSWeWrMe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
z-engine now ships stable tags for both supported PHP minors —
8.4.2on the 8.4 line and8.5.0on the 8.5 line — so this package no longer has to consume development branches."lisachenko/z-engine": "8.4.x-dev || 8.5.x-dev"→"~8.4.2 || ~8.5.0""minimum-stability": "dev"/"prefer-stable": truedroppedWhy the tilde and not a caret
One z-engine release line per supported PHP minor:
~8.4.2admits patch releases inside the 8.4 line but never the 8.5 line, and~8.5.0does the same for 8.5. A caret would span both lines and any future one, so a z-engine built for PHP 8.6 could be installed here before this package claims to support 8.6.Resolution stays automatic: each z-engine tag declares its own platform requirement (
~8.4.0for 8.4.x,~8.5.0for 8.5.x), so only one line can satisfy a given runtime, andCore::init()still enforces the exact match at boot.Dropping the stability pair matters more here than elsewhere — this package is tagged, so a consumer installing
lisachenko/immutable-objectno longer inheritsminimum-stability: devthrough its dependency tree.Side effect worth noting: the CI
lowestleg now resolves real tags (8.4.2 on PHP 8.4, 8.5.0 on PHP 8.5) instead of a branch tip, so the floor it tests is a version that actually exists and stays fixed between runs.Testing
.phptpass.phptpassUnrelated finding while verifying (no action in this PR)
On a build with
opcache.enable_cli=1, the whole immutability guarantee silently disappears on PHP 8.5:ImmutableHandler::install()hooksImmutableInterfaceviasetInterfaceGetsImplementedHandler(), and with opcache warm the implementor is linked without that handler running, sosetWritePropertyHandler()is never installed and$object->publicProperty = 42just succeeds — no exception, no warning.Reproduced against both
8.5.x-devand8.5.0(identical commits), so it predates this change and is not caused by it. It disappears entirely with-d opcache.enable_cli=0, which is how CI runs and how the tests above were run. The sibling packages document the same property from the other direction ("op_arrays compiled before the hook existed are served as-is until invalidated"), but here the failure mode is silent rather than merely inert, which seems worth an issue of its own — happy to open one with the minimal reproducer if useful.Generated by Claude Code