Update Nginx configuration to replace $http_host with $host$is_request_port$request_port for better compatibility#620
Draft
nemchik wants to merge 3 commits into
Draft
Update Nginx configuration to replace $http_host with $host$is_request_port$request_port for better compatibility#620nemchik wants to merge 3 commits into
nemchik wants to merge 3 commits into
Conversation
…ort for better compatibility Signed-off-by: Eric Nemchik <eric@nemchik.com>
Signed-off-by: Eric Nemchik <eric@nemchik.com>
Contributor
|
I am a bot, here is the pushed image/manifest for this PR for commit a393925 :
|
Contributor
|
I am a bot, here is the pushed image/manifest for this PR for commit 69afc4d :
|
…for improved compatibility Signed-off-by: Eric Nemchik <eric@nemchik.com>
Contributor
|
I am a bot, here is the pushed image/manifest for this PR for commit a2509cc :
|
nemchik
marked this pull request as draft
July 18, 2026 21:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs alpine 3.24 rebase for nginx 1.29.3 or higher (alpine 3.24 has nginx 1.30.3)
First commit switched from
$http_hostto$host:$server_portbut this breaks when standard ports (80/443) are used.From FonduemangVI on Discord
This misses the need for handling non-standard ports (ex: 8443) for the users that do that.
nginx has some variables to solve it though:
$host$is_request_port$request_portis the current recommended solution.I do not run proxy auth currently, so I have not tested those changes.