Skip to content

installer: Feed LUKS passphrase to cryptsetup on stdin #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ggiesen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

installer: Feed LUKS passphrase to cryptsetup on stdin #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions usr/lib/live-installer/installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import gettext
import parted
import partitioning
import shlex
from functools import cmp_to_key

gettext.install("live-installer", "/usr/share/locale")
Expand Down Expand Up @@ -442,12 +441,18 @@ def create_partitions(self):
disk_device = parted.getDevice(self.setup.disk)
partitioning.full_disk_format(disk_device, create_boot=(self.auto_boot_partition is not None), create_swap=(self.auto_swap_partition is not None))

# Encrypt root partition
# Encrypt root partition. The passphrase is fed to cryptsetup on
# stdin (--key-file -), never as a command argument: this keeps it
# out of the process table (ps) and out of any logs. Previously the
# engine built 'echo -n <pass> | cryptsetup ...', so the passphrase
# was briefly visible to any local user running ps.
if self.setup.luks:
print(" --> Encrypting root partition %s" % self.auto_root_partition)
os.system("echo -n %s | cryptsetup luksFormat -c aes-xts-plain64 -h sha256 -s 512 %s" % (shlex.quote(self.setup.passphrase1), self.auto_root_partition))
subprocess.run("cryptsetup luksFormat -c aes-xts-plain64 -h sha256 -s 512 --key-file - %s" % self.auto_root_partition,
shell=True, input=self.setup.passphrase1.encode("utf-8"))
print(" --> Opening root partition %s" % self.auto_root_partition)
os.system("echo -n %s | cryptsetup luksOpen %s lvmmint" % (shlex.quote(self.setup.passphrase1), self.auto_root_partition))
subprocess.run("cryptsetup luksOpen --key-file - %s lvmmint" % self.auto_root_partition,
shell=True, input=self.setup.passphrase1.encode("utf-8"))
self.auto_root_partition = "/dev/mapper/lvmmint"

# Setup LVM
Expand Down