test(api): unit-test createTaskEvent via injectable db factory (#430 follow-up) - #432
Merged
Merged
Conversation
Follow-up to PR #430 (SSE rework). packages/api/src/core/db.ts — now packages/api/src/integrations/db.ts — built the neon() client inside getDb() with no seam to substitute it, so createTaskEvent could not be unit-tested in isolation. Refactor (surgical, public API unchanged): - Extract client construction into createDb(connString?) factory. - getDb() delegates to createDb(), same lazy import-safe behavior. - Add setDb()/resetDb() test-only DI seam over the cached singleton. Tests for createTaskEvent (mock SqlClient via DI, no network): - (a) enrichment SELECT fails -> event still emitted without enrichment (HIGH-1 from #430: SELECT failure must never suppress the emit). - (b) happy path -> event emitted enriched with taskStatus. - (c) INSERT fails -> rejection propagates and no event is emitted (documents current behavior: the INSERT ... RETURNING has no try/catch, so it throws before the broadcast block). - no SSE listeners -> enrichment SELECT is skipped (RML-716 gating).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.