feat(codex): publish verified routed service tiers - #1521
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⏳ DRAFT
What to do
Review readiness checklist
1/4 boxes ticked. This PR stays in draft until every box above is ticked. |
|
The implementation and focused verification are green. The only blocked gate is the repository security-boundary rule because this PR touches |
3425900 to
e12d917
Compare
|
Rebased onto current |
e12d917 to
15e1734
Compare
|
Rebased and force-with-lease pushed onto current dev@cbbfdd8773e68a5dc2391ddeb32f33a225373c1a; new head is 15e1734. Fresh local proof: capability/catalog/runtime focused suite 309/309, 1167 assertions; typecheck, privacy scan, and diff check passed. The only remaining repository gate is maintainer sponsorship for the narrow provider-management validation/public DTO change in src/server/auth-cors.ts; I am leaving the PR Draft and will not bypass that security-boundary rule. |
|
The security-boundary gate is now addressed by a real scope split, not by weakening validation: commit moves the new service-tier validation and public DTO projection into , removes the two additions from , and keeps POST/PATCH validation plus projection behavior intact. The diff no longer changes the protected auth-cors file. Fresh proof after the split: capability management projection/validation and persistence tests pass; related catalog/runtime/Chat tests 229/229; typecheck, privacy scan, and diff check pass. Please let hygiene/enforce-target rerun and review the new management-only module. |
|
The security-boundary gate is now addressed by a real scope split, not by weakening validation: commit Fresh proof after the split: capability management projection/validation and persistence tests pass; related catalog/runtime/Chat tests 229/229; typecheck, privacy scan, and diff check pass. Please let hygiene/enforce-target rerun and review the new management-only module. |
|
Initial maintainer review on exact head The scope split out of I am keeping this draft pending deeper review and executed exact-head CI. Please do not merge yet. The next review must verify at least these boundaries:
If those checks hold on current |
Summary
modelSupportsServiceTiercapability overrides with a fail-closed provider-levelfalseboundary.service_tieronly for explicitly verifiedopenai-chatandopenai-responsesroutes.src/server/auth-cors.ts.dev@cbbfdd8773e68a5dc2391ddeb32f33a225373c1a; current head:5224f1a3ff38.Refs #1436
Refs #1504
Refs #1512
Verification
bun test --isolate --max-concurrency 1 tests/service-tier-capability.test.ts tests/openai-chat-hardening.test.ts tests/responses-parser.test.ts tests/codex-catalog.test.ts tests/route-decision-trace.test.ts tests/routing-profile.test.ts tests/routing-profile-editor-data.test.ts— 309 passed, 0 failed, 1167 assertions before the management-boundary split.bun run typecheck— passed after the split.bun run privacy:scan— passed after the split.git diff --check— passed.bun run testresult is not claimed; the suite contains current baseline/environment failures unrelated to this focused change.Checklist
devcommit.Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
All CI tests are green on my local testing.
I pushed my PR to the latest
devcommit.I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.