order: add rev_* orders - #473
Merged
james-d-mitchell merged 3 commits intoAug 19, 2026
Merged
Conversation
james-d-mitchell
added
the
libsemigroups-feature-not-yet-supported
| :only-document-once: | ||
| Compare two words using reversed lexicographic ordering. | ||
|
|
||
| The words are read from right to left before being compared. |
Member
Author
There was a problem hiding this comment.
This phrasing is off, the words aren't read before they are compared, they are read from right to left as they are compared, this should be fixed in a bunch of places.
Member
Author
There was a problem hiding this comment.
Fixed these too
james-d-mitchell
force-pushed
the
rev-orders
branch
from
August 19, 2026 10:10
82348c8 to
53896d6
Compare
Joseph-Edwards
requested changes
Aug 19, 2026
Joseph-Edwards
left a comment
Joseph-Edwards
left a comment
Collaborator
There was a problem hiding this comment.
Some small doc tweaks, then I am happy for this to be merged. Thanks @james-d-mitchell!
james-d-mitchell
force-pushed
the
rev-orders
branch
from
August 19, 2026 12:05
2388882 to
a212661
Compare
james-d-mitchell
enabled auto-merge (squash)
August 19, 2026 12:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the "rev_" versions of the reduction orders. This PR shouldn't be merged until the other order PRs are first.