(cheevos) fix game identification for buffered cue files - #19355
Merged
Conversation
Contributor
|
Spotting a C89 build error there that needs fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where attempting to load a Sega CD cue file in the picodrive core reports "unsupported console for buffer hash".
The behavioral override extensions for the PicoDrive core were updated to include "cue" last November.
As a result, the frontend uses the needs_fullpath from the content override data instead of the needs_fullpath from the system info, and the content override data does not claim it needs the full path, so the cue file gets buffered and then it attempts to hash the cue file instead of loading the associated disc.
Similarly, the new virtualjaguar core does not set
CONTENT_INFO_FLAG_NEED_FULLPATH, so the cue file gets buffered when loading a Jaguar CD game, and the hashing code doesn't try to process the contents of the cue.As these cores support both CD and non-CD games, it's easier to just override the behavior when calling the hasher. That will also handle any other cores that would be similarly affected.
Related Issues
n/a
Related Pull Requests
n/a
Reviewers
@Sanaki