rgui_config_directory: Rename 'Configuration files' label to Configurations and add Configuration Files, Overrides, and Manage Core Options to the sub-label - #19248
Open
davidhedlund wants to merge 5 commits into
Conversation
…ription to its sub-label Fixes: * libretro#19200
Collaborator
|
Seems good. Thanks for working on it. |
Contributor
|
Looks fine to me! |
RobLoach
reviewed
Jul 29, 2026
Comment on lines
+70
to
+72
| "This directory stores files managed by menu items located in " | ||
| "Configuration Files, Overrides, and—for core overrides on " | ||
| "supported cores—Manage Core Options sub-menus.") |
Member
There was a problem hiding this comment.
This directory stores files managed by menu items located in Configuration Files, Overrides, and—for core overrides on supported cores—Manage Core Options sub-menus.
Two emdashes and sounds rather convoluted? I'd recommend something a bit simpler...
Suggested change
| "This directory stores files managed by menu items located in " | |
| "Configuration Files, Overrides, and—for core overrides on " | |
| "supported cores—Manage Core Options sub-menus.") | |
| "This directory stores configuration files for general settings, " | |
| "core options, and overrides." |
Contributor
Author
There was a problem hiding this comment.
Two emdashes and sounds rather convoluted?
My latest revision:
"This directory stores configuration files managed by Configuration File," "Overrides, and Manage Core Options sub-menus."
- Removed: Per your recommendation, I removed
, and—for core overrides on supported cores—. It's much shorter now, thank you for the feedback! - Retained: I kept
Configuration Files, Overrides, and Manage Core Options menu items. Kindly review these two items for context, since it took a few hours to write the issue, and the rationale for this PR:- The sub-label Rationale in the top post, which explains why this is necessary.
- The "Configuration files" behavior section in rgui_config_directory: Rename 'Configuration files' label to
Configurationsand addConfiguration Files, Overrides, and Manage Core Optionsto the sub-label #19200).
Co-authored-by: Rob Loach <robloach@gmail.com>
Restore Configuration Files, Overrides, and Manage Core Options without making the text longer. This aligns with how other labels and sub-labels reference each other rather than using general descriptions. Note the capital 'File Browser' used specifically as a reference here: under Settings → User Interface → File Browser, the option Filter by current Core has the sub-label: 'Filter files being shown in File Browser by current core.'
Configurations and add Configuration Files, Overrides, and Manage Core Options to the sub-label
Corrected `Configuration Files` (plural) to `Configuration File` (singular)
restore `sub-menus` from my previous revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace:
With:
Rationale:
Configurations. Matches the defaultconfigdestination directory used by thergui_config_directoryvariable.Configuration files: Lowercase initial words are non-standard for labels; standardizing "Configuration Files" to capital "F" risks confusing users into thinking it only affects items underMain Menu → Configuration Files, whereas it is also used for saving overrides (e.g.,Quick Menu → Overrides → Save Core OverridesandQuick Menu → Core Options → Save Game Options).Overridesto the label to prevent confusion that it is limited exclusively toQuick Menu → Overrides(capital "O"), given that it also handles other items likeQuick Menu → Core Options. Additionally, since overrides are inherently configurations, using the simpler termConfigurationskeeps the label concise and all-encompassing.Configuration Files, Overrides, and Manage Core Options, along with detailed explanations of their functions.rgui_config_directory. For instance,Manage Remap Files(for loaded content) is often mistakenly assumed to be part of this feature, even though it has its own separateInput Remapsdirectory (input_remapping_directory).sub-menus: Indicating that these settings are nested within those submenus.Default configuration file is stored in this directory.:Main Menu → Configuration Filethat does not save to theSettings → Directory → Configuration filesdirectory.Configuration Filesin the the new sub-label.Related Issues
Configurationsand addConfiguration Files, Overrides, and Manage Core Optionsto the sub-label #19200Reviewers
@hizzlekizzle @Ryunam