Skip to content

rgui_config_directory: Rename 'Configuration files' label to Configurations and add Configuration Files, Overrides, and Manage Core Options to the sub-label - #19248

Open
davidhedlund wants to merge 5 commits into
libretro:masterfrom
davidhedlund:patch-1

Conversation

@davidhedlund

@davidhedlund davidhedlund commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Replace:

Configuration files
Default configuration file is stored in this directory.

With:

Configurations
This directory stores files managed by menu items located in Configuration Files, Overrides, and—for core overrides on supported cores—Manage Core Options sub-menus.

Rationale:

  • Label:
    • Add: Configurations. Matches the default config destination directory used by the rgui_config_directory variable.
    • Remove Configuration files: Lowercase initial words are non-standard for labels; standardizing "Configuration Files" to capital "F" risks confusing users into thinking it only affects items under Main Menu → Configuration Files, whereas it is also used for saving overrides (e.g., Quick Menu → Overrides → Save Core Overrides and Quick Menu → Core Options → Save Game Options).
    • Avoid: Adding Overrides to the label to prevent confusion that it is limited exclusively to Quick Menu → Overrides (capital "O"), given that it also handles other items like Quick Menu → Core Options. Additionally, since overrides are inherently configurations, using the simpler term Configurations keeps the label concise and all-encompassing.
  • Sub-label
    • Added
      • Configuration Files, Overrides, and Manage Core Options, along with detailed explanations of their functions.
        • This aligns with how other labels and sub-labels reference each other rather than using general descriptions. Note the capital 'File Browser' used specifically as a reference here: under Settings → User Interface → File Browser, the option Filter by current Core has the sub-label: 'Filter files being shown in File Browser by current core.'
        • This clarifies what isn't included for rgui_config_directory. For instance, Manage Remap Files (for loaded content) is often mistakenly assumed to be part of this feature, even though it has its own separate Input Remaps directory (input_remapping_directory).
      • sub-menus: Indicating that these settings are nested within those submenus.
    • Remove Default configuration file is stored in this directory.:
      • Context from Issue Update "Save Main Configuration" sub-label (bypasses custom save directory) #19211: The "Save Main Configuration" is the only menu item under Main Menu → Configuration File that does not save to the Settings → Directory → Configuration files directory.
      • Even if this behavior is updated in the future, the primary file will remain associated with the configuration files section, which is explicitly covered by Configuration Files in the the new sub-label.

Related Issues

Reviewers

@hizzlekizzle @Ryunam

@hizzlekizzle

Copy link
Copy Markdown
Collaborator

Seems good. Thanks for working on it.

@Ryunam

Ryunam commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Looks fine to me!

Comment thread settings/settings_def_dir_core.h Outdated
Comment on lines +70 to +72
"This directory stores files managed by menu items located in "
"Configuration Files, Overrides, and—for core overrides on "
"supported cores—Manage Core Options sub-menus.")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This directory stores files managed by menu items located in Configuration Files, Overrides, and—for core overrides on supported cores—Manage Core Options sub-menus.

Two emdashes and sounds rather convoluted? I'd recommend something a bit simpler...

Suggested change
"This directory stores files managed by menu items located in "
"Configuration Files, Overrides, and—for core overrides on "
"supported cores—Manage Core Options sub-menus.")
"This directory stores configuration files for general settings, "
"core options, and overrides."

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two emdashes and sounds rather convoluted?

My latest revision:

 "This directory stores configuration files managed by Configuration File,"
 "Overrides, and Manage Core Options sub-menus."

davidhedlund and others added 2 commits August 2, 2026 02:09
Co-authored-by: Rob Loach <robloach@gmail.com>
Restore Configuration Files, Overrides, and Manage Core Options without making the text longer.

This aligns with how other labels and sub-labels reference each other rather than using general descriptions. Note the capital 'File Browser' used specifically as a reference here: under Settings → User Interface → File Browser, the option Filter by current Core has the sub-label: 'Filter files being shown in File Browser by current core.'
@davidhedlund davidhedlund changed the title Rename 'Configuration files' label and add a correct and precise description to its sub-label rgui_config_directory: Rename 'Configuration files' label and add a correct and precise description to its sub-label Aug 2, 2026
@davidhedlund davidhedlund changed the title rgui_config_directory: Rename 'Configuration files' label and add a correct and precise description to its sub-label rgui_config_directory: Rename 'Configuration files' label to Configurations and add Configuration Files, Overrides, and Manage Core Options to the sub-label Aug 3, 2026
Corrected `Configuration Files` (plural) to `Configuration File` (singular)
restore `sub-menus` from my previous revision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants