feat: declare the queue worker's redis requirement - #46
Open
geodro wants to merge 1 commit into
Open
Conversation
A queue worker dies on a DNS error when the site's queue connection is redis and lerd-redis is not running, and the message PHP produces says nothing about which service to start. lerd caught that with a check written into the binary, which put the env key, the worker name and the service name in Go, where no framework knowledge belongs. The requirement is declared here instead, scoped by when_env so it only applies to a site whose .env actually asks for the redis connection. Binaries that predate the field ignore it and keep their own check, so the rollout costs nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A queue worker dies on a DNS error when the site's queue connection is redis and lerd-redis is not running, and the message PHP produces says nothing about which service to start. lerd caught that with a check written into the binary, which put the env key, the worker name and the service name in Go, where no framework knowledge belongs.
The requirement is declared here instead, on every Laravel version that has a queue worker, scoped by when_env so it only applies to a site whose .env actually asks for the redis connection. Binaries that predate the field ignore it and keep their own check, so nothing changes for an install that has not updated yet.