🧹 refactor: remove hardcoded answers from adventure scripts#23
🧹 refactor: remove hardcoded answers from adventure scripts#23lemononmars wants to merge 2 commits into
Conversation
Remove hardcoded answers from script properties by replacing static strings with dynamic getter properties that interpolate `this.answer`. This ensures the scripts accurately reflect the correct answer dynamically while maintaining existing behavior. Co-authored-by: lemononmars <26631189+lemononmars@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🎯 What: The code health issue addressed
Removed hardcoded answers (like "debug") from the
scriptproperties of adventure levels 4, 6, 7, and 8 insrc/lib/data/adventure_data.tsand replaced them with dynamic getters using string interpolation.💡 Why: How this improves maintainability
Hardcoding data duplication (e.g.
answer: 'debug'andscript: 'console.log("Password: debug")') leads to synchronization bugs when updating values. By dynamically interpolatingthis.answerinto the script via a getter property, the script will always output the correct answer even if the level's answer is changed, improving code maintainability.✅ Verification: How you confirmed the change is safe
get script() { return \...${this.answer}...`; }`).npx tsxto confirm that thescriptgetter accurately evaluates and returns the correct string (with interpolation) when accessed as a property.package-lock.jsonchanges out of the commit to keep the PR highly focused and clean.✨ Result: The improvement achieved
A more dynamic, maintainable configuration for adventure puzzle scripts that automatically adapts to changes in the
answerproperty, without altering any runtime functionality.PR created automatically by Jules for task 4956173039254718610 started by @lemononmars