Skip to content

🧹 refactor: remove hardcoded answers from adventure scripts#23

Open
lemononmars wants to merge 2 commits into
mainfrom
fix/adventure-hardcoded-scripts-4956173039254718610
Open

🧹 refactor: remove hardcoded answers from adventure scripts#23
lemononmars wants to merge 2 commits into
mainfrom
fix/adventure-hardcoded-scripts-4956173039254718610

Conversation

@lemononmars

Copy link
Copy Markdown
Owner

🎯 What: The code health issue addressed
Removed hardcoded answers (like "debug") from the script properties of adventure levels 4, 6, 7, and 8 in src/lib/data/adventure_data.ts and replaced them with dynamic getters using string interpolation.

💡 Why: How this improves maintainability
Hardcoding data duplication (e.g. answer: 'debug' and script: 'console.log("Password: debug")') leads to synchronization bugs when updating values. By dynamically interpolating this.answer into the script via a getter property, the script will always output the correct answer even if the level's answer is changed, improving code maintainability.

Verification: How you confirmed the change is safe

  • Verified the structure and existing string values of all modified levels.
  • Applied the patch to convert the static strings into object getters (get script() { return \...${this.answer}...`; }`).
  • Ran ad-hoc typescript scripts locally via npx tsx to confirm that the script getter accurately evaluates and returns the correct string (with interpolation) when accessed as a property.
  • Ensured formatting/lint checks on the modified file were clean.
  • Tests (which were unaffected) were verified to pass.
  • Dropped extraneous local test files and unintended package-lock.json changes out of the commit to keep the PR highly focused and clean.

Result: The improvement achieved
A more dynamic, maintainable configuration for adventure puzzle scripts that automatically adapts to changes in the answer property, without altering any runtime functionality.


PR created automatically by Jules for task 4956173039254718610 started by @lemononmars

Remove hardcoded answers from script properties by replacing static strings
with dynamic getter properties that interpolate `this.answer`. This ensures
the scripts accurately reflect the correct answer dynamically while
maintaining existing behavior.

Co-authored-by: lemononmars <26631189+lemononmars@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codebreaker Ready Ready Preview, Comment Jul 16, 2026 5:03pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant