[DEN-3467] Add replay-bounded command envelopes and receipts - #2
Draft
ORESoftware wants to merge 3 commits into
Draft
[DEN-3467] Add replay-bounded command envelopes and receipts#2ORESoftware wants to merge 3 commits into
ORESoftware wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandEnvelopewith device/boot identity, monotonic sequence, issue/expiry timestamps, and canonical SHA-256 payload digestCommandReceiptwith accepted/applied/duplicate/expired/unsupported/rejected/failed outcomesDeviceEvent::AckCompatibility boundary
This is an additive first slice of DEN-3467. It intentionally does not remove or reinterpret the legacy ACK, add protocol negotiation to
Hello, or implement device-side persistent replay windows. Those changes require coordinated controller/server/SDK vectors under DEN-3470.Validation
GitHub Actions passes:
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all-targets --all-featuresThe first run surfaced only rustfmt layout differences; the exact CI diff was applied and the full rerun passed.
Linear: https://linear.app/denman/issue/DEN-3467/leddy-version-expire-and-replay-protect-device-commands-and