feat: variables for all code colors, coherent hover behavior - #954
Merged
Conversation
This PR fixes limitations in highlighting behavior: * The colors of messages are more consistently controlled by variables, elminating a problem with warning hovers and making it easier to configure all colors. * Hover highlights for nested messages are fixed, and their CSS simplified. * When message and token hover spans coincide, they are collapsed, rather than having one of them win over the other. Before, this was done only for multiple message spans. * Some edge cases related to tooltip precedence are fixed. An added gallery page in the tests demonstrates these combinations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes limitations in highlighting behavior:
The colors of messages are more consistently controlled by variables, elminating a problem with warning hovers and making it easier to configure all colors.
Hover highlights for nested messages are fixed, and their CSS simplified.
When message and token hover spans coincide, they are collapsed, rather than having one of them win over the other. Before, this was done only for multiple message spans.
Some edge cases related to tooltip precedence are fixed.
An added gallery page in the tests demonstrates these combinations.