-
Notifications
You must be signed in to change notification settings - Fork 66
feat: add more tactic examples and documentation #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcreedcmu
wants to merge
18
commits into
leanprover:main
Choose a base branch
from
jcreedcmu:jcreed/tactics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
aae925b
feat: add more tactic examples and documentation
jcreedcmu 6ab83ce
fix prose linter errors
jcreedcmu 962cf9f
add some more text inside examples
jcreedcmu 656abcf
Update Manual/Tactics/Reference.lean
jcreedcmu 5f3d093
Update Manual/Tactics/Reference.lean
jcreedcmu 2513540
Update Manual/Tactics/Reference.lean
jcreedcmu ebb8ed5
Update Manual/Tactics/Reference.lean
jcreedcmu 08018b4
Update Manual/Tactics/Reference.lean
jcreedcmu 5bde517
Update Manual/Tactics/Reference.lean
jcreedcmu 874d72b
Update Manual/Tactics/Reference.lean
jcreedcmu 9798ffb
Update Manual/Tactics/Reference.lean
jcreedcmu 86bcf7b
Update Manual/Tactics.lean
jcreedcmu 42249af
Update Manual/Tactics/Reference.lean
jcreedcmu f542284
Update Manual/Tactics/Reference.lean
jcreedcmu ed6fb2b
Update Manual/Tactics/Reference.lean
jcreedcmu 27ec7a1
Update Manual/Tactics.lean
jcreedcmu a16ddd3
review comments
jcreedcmu dbed432
address review comments
jcreedcmu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally I'd use
generalizinghere rather than a low-levelrevert-then-inductiondance.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't ever use revert, so I didn't have a strong notion of how to make a super unimpeachably high-quality example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. It is a kind of low-level thing that I expect I'd only really use in a tactic macro or something. I'd just leave the example alone.