test: add regression test for F-01 field canonicity check#258
Open
aryaethn wants to merge 1 commit into
Open
Conversation
The MontyField31 Deserialize impl rejects non-canonical values (>= p), the fix for audit finding F-01, but had no test -- a refactor could silently drop the check and reintroduce the critical bug. Add a unit test asserting values >= p are rejected and canonical values in [0, p) are accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
MontyField31Deserializeimpl rejects non-canonical serialized values (val >= p) — the fix for audit finding F-01 (non-canonical field deserialization, rated Critical). But that check has no regression test: a future refactor could silently drop or weaken it and reintroduce the bug while CI stays green.This adds a unit test asserting that deserializing a value
>= p(the modulus,p + 1,u32::MAX) is rejected, while canonical values in[0, p)are accepted. The quintic extension and packed types deserialize each of their coefficients through this same checked base-field path.Tests only — no production code changes.
Tested