revert(mcp): back out leadbay_getting_started (#175) - #178
Closed
ArtyETH06 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backs out the
#175merge (24cf7cd).mainreturns toe4a8280's parent state.#175was merged at 13:43 UTC; Codex's review landed at 13:49 — six minutes later, so its findings never gated the merge. Eight are open, four of them P1:leadId, butleadbay_enrich_titlesonly readsleadIds?: string[]. The unknown key is ignored, so the confirmed call falls back to the default wishlist selection withconfirm/emailset — it can spend on the whole wishlist instead of the one drafted lead._metato result objects in place; those stick to the module-level singleton and leak into later calls.runSessionLiverecords every call asok: true, output_len: 0and never updates fromtool_result, so a failed call still satisfiesrequired_callsand reaches the judge as a success.backendFixturesto block the paid launch, but the live runner ignores fixtures.Plus four P2s: the tour dead-ends at gate 4 under
LEADBAY_MCP_WRITE=0(enrich_titlesis a write tool);WORKFLOWS.mdstill requires the CRM/scheduling gates that were removed; theSTOPinclude forces a final line that contradicts "the 1:1 offer must be last";allowed_callsis declared but never enforced.Nothing shipped —
auto-tag.ymlonly fires onpackages/mcp/package.json, which#175never touched. npmlatestis still0.28.0from717b02c.Gates on this branch:
prompts:checkclean, build, typecheck, and 1,289 tests all pass.Supersedes #176 and #177, both closed — one decision should be one PR. The re-land with the eight fixes comes back as its own PR once this lands.