fix(deps): bump eventsource to v1.11.1#770
Merged
aaron-zeisler merged 2 commits intoJul 23, 2026
Merged
Conversation
Picks up the fix for a stream-shutdown deadlock (launchdarkly/eventsource#60): when Close raced with an in-flight event, the stream goroutine wedged and stream.Events was never closed, hanging any consumer draining it on shutdown. In Relay this hung relay.Close via the auto-config StreamManager, surfacing as the intermittently-hanging TestAutoConfigAddEnvironmentWithExpiringSDKKeyDoesNotPanicWhenInitFails. Supersedes the ld-relay-side workaround in #733.
aaron-zeisler
marked this pull request as ready for review
July 22, 2026 18:18
aaron-zeisler
marked this pull request as draft
July 22, 2026 18:37
…urce-concurrent-keys
aaron-zeisler
marked this pull request as ready for review
July 22, 2026 19:52
keelerm84
approved these changes
Jul 23, 2026
aaron-zeisler
deleted the
aaronz/SDK-2549/bump-eventsource-concurrent-keys
branch
July 23, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
github.com/launchdarkly/eventsourcev1.11.0 → v1.11.1. Supersedes the ld-relay-side workaround in #733.Background
v1.11.1 fixes a stream-shutdown deadlock (launchdarkly/eventsource#60): when
Closeraced with an in-flight event, the stream goroutine'sdiscardCurrentStreamwedged (it drained its internalerrschannel beforeeventswhile the decoder was blocked sending onevents), sostream.Eventswas never closed and any consumer draining it on shutdown hung forever.In Relay this hung
relay.Close()via the auto-configStreamManager(consumeStream's deferred drain), surfacing as the intermittently-hangingTestAutoConfigAddEnvironmentWithExpiringSDKKeyDoesNotPanicWhenInitFails(panic: test timed out after 10m0s). Fixing eventsource at the root removes the hang with no ld-relay code change, so this replaces the workaround PR #733.Changes
go.mod/go.sumonly.Note
Low Risk
Patch-level dependency update with no ld-relay code changes; risk is limited to eventsource/SSE shutdown behavior, which this release is meant to improve.
Overview
Bumps
github.com/launchdarkly/eventsourcefrom v1.11.0 to v1.11.1 (go.mod/go.sumonly). No ld-relay application code changes.v1.11.1 fixes a stream-shutdown deadlock when
Closeraces with an in-flight event: the stream goroutine could wedge and never closestream.Events, so shutdown paths that drain that channel (e.g. auto-configStreamManager/consumeStream, and thusrelay.Close()) could hang indefinitely. That behavior showed up as intermittent test timeouts such asTestAutoConfigAddEnvironmentWithExpiringSDKKeyDoesNotPanicWhenInitFails. This dependency bump is intended to fix the issue at the library root and supersede an ld-relay workaround (PR #733).Reviewed by Cursor Bugbot for commit 45acf95. Bugbot is set up for automated code reviews on this repo. Configure here.