Skip to content

fix(deps): bump eventsource to v1.11.1#770

Merged
aaron-zeisler merged 2 commits into
feat/concurrent-keysfrom
aaronz/SDK-2549/bump-eventsource-concurrent-keys
Jul 23, 2026
Merged

fix(deps): bump eventsource to v1.11.1#770
aaron-zeisler merged 2 commits into
feat/concurrent-keysfrom
aaronz/SDK-2549/bump-eventsource-concurrent-keys

Conversation

@aaron-zeisler

@aaron-zeisler aaron-zeisler commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps github.com/launchdarkly/eventsource v1.11.0 → v1.11.1. Supersedes the ld-relay-side workaround in #733.

Background

v1.11.1 fixes a stream-shutdown deadlock (launchdarkly/eventsource#60): when Close raced with an in-flight event, the stream goroutine's discardCurrentStream wedged (it drained its internal errs channel before events while the decoder was blocked sending on events), so stream.Events was never closed and any consumer draining it on shutdown hung forever.

In Relay this hung relay.Close() via the auto-config StreamManager (consumeStream's deferred drain), surfacing as the intermittently-hanging TestAutoConfigAddEnvironmentWithExpiringSDKKeyDoesNotPanicWhenInitFails (panic: test timed out after 10m0s). Fixing eventsource at the root removes the hang with no ld-relay code change, so this replaces the workaround PR #733.

Changes

go.mod / go.sum only.


Note

Low Risk
Patch-level dependency update with no ld-relay code changes; risk is limited to eventsource/SSE shutdown behavior, which this release is meant to improve.

Overview
Bumps github.com/launchdarkly/eventsource from v1.11.0 to v1.11.1 (go.mod / go.sum only). No ld-relay application code changes.

v1.11.1 fixes a stream-shutdown deadlock when Close races with an in-flight event: the stream goroutine could wedge and never close stream.Events, so shutdown paths that drain that channel (e.g. auto-config StreamManager / consumeStream, and thus relay.Close()) could hang indefinitely. That behavior showed up as intermittent test timeouts such as TestAutoConfigAddEnvironmentWithExpiringSDKKeyDoesNotPanicWhenInitFails. This dependency bump is intended to fix the issue at the library root and supersede an ld-relay workaround (PR #733).

Reviewed by Cursor Bugbot for commit 45acf95. Bugbot is set up for automated code reviews on this repo. Configure here.

Picks up the fix for a stream-shutdown deadlock (launchdarkly/eventsource#60): when Close raced with an in-flight event, the stream goroutine wedged and stream.Events was never closed, hanging any consumer draining it on shutdown. In Relay this hung relay.Close via the auto-config StreamManager, surfacing as the intermittently-hanging TestAutoConfigAddEnvironmentWithExpiringSDKKeyDoesNotPanicWhenInitFails. Supersedes the ld-relay-side workaround in #733.
@aaron-zeisler
aaron-zeisler marked this pull request as ready for review July 22, 2026 18:18
@aaron-zeisler
aaron-zeisler requested a review from a team as a code owner July 22, 2026 18:18
@aaron-zeisler
aaron-zeisler marked this pull request as draft July 22, 2026 18:37
@aaron-zeisler
aaron-zeisler marked this pull request as ready for review July 22, 2026 19:52
@aaron-zeisler
aaron-zeisler merged commit 7efb32d into feat/concurrent-keys Jul 23, 2026
16 checks passed
@aaron-zeisler
aaron-zeisler deleted the aaronz/SDK-2549/bump-eventsource-concurrent-keys branch July 23, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants