ci: Verify streaming connection close contract test from harness PR - #514
Closed
kinyoklion wants to merge 1 commit into
Closed
ci: Verify streaming connection close contract test from harness PR#514kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Temporary do-not-merge branch: builds the sdk-test-harness from the PR branch that adds the client-side streaming connection-lifecycle test and runs only that test against the contract test service. Other CI jobs are removed to avoid burning macOS runner time on a throwaway verification.
Member
Author
|
Verification complete: the connection-lifecycle test from sdk-test-harness PR #377 RAN and PASSED against the iOS SDK on this runner (Test Summary: 16 total, 13 skipped, 3 ran — job https://github.com/launchdarkly/ios-client-sdk/actions/runs/30669861251/job/91285093960). Closing this temporary branch as planned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge — temporary CI verification, will be closed after the run.
Uses the macOS CI runner to verify the iOS SDK against the new client-side contract test proposed in launchdarkly/sdk-test-harness#377 (
streaming/connection lifecycle/SDK closes streaming connection when client is closed), since that harness change is unreleased and the test can't run on Linux hosts.Changes (both temporary):
jb/sdk-2669/fdv1-close-contract-testbranch instead of downloading a released binary, and runs only the connection-lifecycle test.ci.ymlis stripped to the contract-tests job so the full macOS build/test matrix doesn't run for this throwaway check.Context: this completes a sweep of the PR #377 test across all SDKs — 9 server-side and 7 client-side SDKs were verified locally (all pass except the Erlang server SDK, fix in launchdarkly/erlang-server-sdk#195); iOS is the one client SDK that needs a macOS host.
SDK-2669