fix: restore client SDK CI to macos-latest with Xcode 26.3 and Android 34 install (SDK-2623) - #326
Open
tanderson-ld wants to merge 1 commit into
Open
fix: restore client SDK CI to macos-latest with Xcode 26.3 and Android 34 install (SDK-2623)#326tanderson-ld wants to merge 1 commit into
tanderson-ld wants to merge 1 commit into
Conversation
…d 34 install (SDK-2623)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 07b1505. Configure here.
| - uses: ./.github/actions/xcode-select | ||
| with: | ||
| xcode-version: '16.2' | ||
| xcode-version: '26.3' |
There was a problem hiding this comment.
Xcode 26.3 absent on macos-latest
High Severity
The workflows move to macos-latest while selecting Xcode 26.3, but the current macos-26 image only ships Xcode 26.5, 26.6, and a 27 preview. The xcode-select step will fail immediately looking for /Applications/Xcode_26.3.app, recreating the same CI break this change aims to fix.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 07b1505. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the interim `macos-15` pin from #302 and addresses the two underlying issues that made the pin necessary. The client SDK CI moves back onto `macos-latest`.
Two issues break the client SDK CI when the runner lands on macOS 26 (the new `macos-latest`):
Changes
The Android install step follows the same pattern as launchdarkly/hello-dotnet-client#21, invoking the .NET Android workload's `InstallAndroidDependencies` MSBuild target so the workload itself declares which platform components it needs. Scoped to the two client-SDK workflows only — not added to the shared `./.github/actions/ci` composite that other SDKs use, since only the client SDK builds `net8.0-android`.
Notes
Test plan
Note
Low Risk
Changes are limited to GitHub Actions for the client SDK; no product code, auth, or customer-facing runtime behavior.
Overview
Unblocks client SDK CI and release on rolling
macos-latest(macOS 26) by undoing the temporarymacos-15pin and fixing the two runner-image mismatches that caused it.Xcode: The shared
xcode-selectaction default and explicit workflow pins move from 16.2 → 26.3, since macOS 26 images no longer ship Xcode 16.2.Runners:
sdk-client-ciandrelease-sdk-client(build+publish) run onmacos-latestagain instead ofmacos-15.Android: Before the shared CI/build steps, the CI and release
buildjobs add .NET 8 setup, workload restore, and anInstallAndroidDependenciesMSBuild target fornet8.0-androidso API 34 is installed when the runner no longer preinstalls it. The releasepublishjob is unchanged aside from runner/Xcode (pack-only, no Android install).Reviewed by Cursor Bugbot for commit 07b1505. Bugbot is set up for automated code reviews on this repo. Configure here.