Skip to content

fix: Disable Foxy separate compilation to avoid Boost.Asio ODR crash #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beekld merged 2 commits into from
Aug 4, 2026
+6 −2
Merged

fix: Disable Foxy separate compilation to avoid Boost.Asio ODR crash #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35478ce
fix: Disable Foxy separate compilation to avoid Boost.Asio ODR crash
beekld Aug 3, 2026
4392bb3
fix: Stop libs/networking from forcing Boost separate compilation
beekld Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,12 @@ find_package(Boost 1.81 REQUIRED COMPONENTS json url coroutine)
message(STATUS "LaunchDarkly: using Boost v${Boost_VERSION}")

set(FOXY_BUILD_TESTING OFF)

# Keep Boost.Asio header-only, matching how consumers compile it. Foxy's
# separate-compilation mode bakes Asio internals into our library whose layout can
# diverge from a consumer's build, causing ODR violations when linked. Force off.
set(FOXY_FAST_BUILD OFF CACHE BOOL "Keep Boost.Asio header-only for ABI compatibility with consumers" FORCE)

add_subdirectory(vendor/foxy)


Expand Down
2 changes: 0 additions & 2 deletions libs/networking/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ target_compile_features(${LIBNAME} PUBLIC cxx_std_17)
target_compile_definitions(${LIBNAME}
PUBLIC
LD_CURL_NETWORKING
BOOST_ASIO_SEPARATE_COMPILATION=1
BOOST_BEAST_SEPARATE_COMPILATION=1
)

# Using PUBLIC_HEADERS would flatten the include.
Expand Down
Loading