ci: prevent script injection in Publish SDK Artifacts workflow - #586
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
ci: prevent script injection in Publish SDK Artifacts workflow#586devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
osm6495
approved these changes
Jul 29, 2026
osm6495
marked this pull request as ready for review
July 29, 2026 17:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates the Wiz finding "Workflow should not use untrusted input in a privileged context" on the
split-inputjob of Publish SDK Artifacts (.github/workflows/manual-sdk-release-artifacts.yml).${{ inputs.sdk_target }}was expanded into therun:body before the shell ran, so the quotes around it offered no protection — a dispatch value likea"; curl … #would execute on the runner, in a workflow whose downstream jobs holdcontents: write,attestations: write, andid-token: write.The value is now interpolated by the runner into the step environment rather than into the script text; the
IFS=':' read -rasplit and bothGITHUB_OUTPUTwrites are unchanged.actionlintis clean on the file.Link to Devin session: https://app.devin.ai/sessions/8c95fd39350c4c5aa16a2dcd1974e09e
Note
Low Risk
Narrow CI hardening with no runtime or product behavior changes; reduces privilege-escalation risk on manual dispatch.
Overview
Fixes a script-injection risk in the Publish SDK Artifacts workflow’s
split-inputjob.${{ inputs.sdk_target }}is no longer expanded inside therun:script; it is passed through a stepenvvariable (SDK_TARGET) and read asINPUT="$SDK_TARGET".The
:split andGITHUB_OUTPUTwrites are unchanged. This matters because downstream jobs use elevated permissions (contents: write, attestations,id-token).Reviewed by Cursor Bugbot for commit b033485. Bugbot is set up for automated code reviews on this repo. Configure here.