Skip to content

fix(ci): validate static workflow identity#2015

Draft
liangshuo-1 wants to merge 1 commit into
mainfrom
fix/semantic-review-workflow-name
Draft

fix(ci): validate static workflow identity#2015
liangshuo-1 wants to merge 1 commit into
mainfrom
fix/semantic-review-workflow-name

Conversation

@liangshuo-1

Copy link
Copy Markdown
Collaborator

Summary

Fix Semantic Review failures after CI adopted the dynamic CI / <PR number> run name. Workflow identity is now verified from the static Actions workflow metadata while preserving the existing fail-closed repository, event, path, and SHA checks.

Changes

  • Resolve the triggering workflow through its validated workflow_id in both the PR quality summary and semantic review jobs.
  • Verify the static workflow name and path, and reject mismatches between workflow metadata and the workflow-run payload path.
  • Add regression coverage that prevents dynamic workflow_run.name from being reused as workflow identity.

Test Plan

  • make script-test (150 tests)
  • make unit-test
  • go vet ./...
  • gofmt -l . produces no output
  • go mod tidy leaves go.mod and go.sum unchanged
  • go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --new-from-rev=origin/main reports 0 issues

Related Issues

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f3083054-52b5-45ee-a4b7-a34702029143

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/semantic-review-workflow-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size/M Single-domain feat or fix with limited business impact label Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant