fix(slides): preserve raw XML output verbatim#2013
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughSlidesXMLGet now preserves fetched XML for raw stdout and file output, removes XML pretty-printing and its dependency, updates output metadata and documentation, and revises tests to validate unchanged server content. ChangesSlides XML output behavior
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant SlidesXMLGet
participant outputSlidesXMLGetContent
participant stdout
participant outputFile
SlidesXMLGet->>outputSlidesXMLGetContent: pass fetched XML content and output flags
outputSlidesXMLGetContent->>stdout: write raw XML when --raw is used
outputSlidesXMLGetContent->>outputFile: save raw XML when --output is used
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep --raw and file output byte-exact by returning the server response without XML reserialization.
liangshuo-1
force-pushed
the
fix/revert-slides-xml-reindent
branch
from
July 22, 2026 13:51
a5f69de to
023fb0f
Compare
liangshuo-1
marked this pull request as ready for review
July 22, 2026 13:52
fangshuyu-768
approved these changes
Jul 22, 2026
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@023fb0f73453f57c4483ac9608cc239fe3956281🧩 Skill updatenpx skills add larksuite/cli#fix/revert-slides-xml-reindent -y -g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the server XML verbatim for
slides +xml-getraw and file output.Changes
Test Plan
go test ./shortcuts/slidesgo mod tidyleaves the worktree cleanSummary by CodeRabbit
New Features
Bug Fixes