feat: add chat member shortcut#1983
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughAdds the ChangesChat member addition
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant ImChatMembersAdd
participant MembersAPI
CLI->>ImChatMembersAdd: validate and confirm request
CLI->>ImChatMembersAdd: execute user and bot batches
ImChatMembersAdd->>MembersAPI: add users
ImChatMembersAdd->>MembersAPI: add bots
MembersAPI-->>ImChatMembersAdd: response lists or errors
ImChatMembersAdd-->>CLI: merged result
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@a0b42632067e8c34548a3b08bad7630ac2f34439🧩 Skill updatenpx skills add larksuite/cli#feat/im-chat-member-add -y -g |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1983 +/- ##
==========================================
+ Coverage 75.05% 75.12% +0.07%
==========================================
Files 901 902 +1
Lines 95391 95738 +347
==========================================
+ Hits 71591 71924 +333
- Misses 18307 18319 +12
- Partials 5493 5495 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
Add a dedicated
im +chat-members-addshortcut so callers can add useropen_idand botapp_idvalues without constructing Meta API JSON. The shortcut preserves partial results, processes users before bots, and provides explicit recovery guidance for unknown outcomes.Changes
ImChatMembersAddrequest validation, dry-run previews, two-request execution, and stable combined output inshortcuts/im/im_chat_members_add.goshortcuts/common/runner.goshortcuts/im/andtests/cli_e2e/im/skills/lark-im/Test Plan
make unit-testpassedoutcome_unknownrecovery case was accepted by explicit human approvallark-cli im +chat-members-add --helpandlark-cli im +chat-members-add --chat-id oc_review123 --bots bot_123 --as user --dry-runRelated Issues
N/A
Summary by CodeRabbit
New Features
im +chat-members-addto add users and bots to group chats.Bug Fixes
Documentation
Tests