Skip to content

feat: card_icon#1973

Open
91-enjoy wants to merge 1 commit into
larksuite:mainfrom
91-enjoy:feat/card_icon
Open

feat: card_icon#1973
91-enjoy wants to merge 1 commit into
larksuite:mainfrom
91-enjoy:feat/card_icon

Conversation

@91-enjoy

@91-enjoy 91-enjoy commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

Card header icon documentation contained invalid tokens (e.g., mail_colorful, approve_colorful) that do not render, and icon guidance lacked precise token enumeration, causing LLM to guess or fabricate icon tokens. This PR replaces
examples with valid tokens and adds a definitive colorful icon reference table.

Changes

  • Add a resource/icons.md colorful icon reference table with 14 exact token strings (calendar_colorful, todo_colorful, vote_colorful, etc.) and a hard rule prohibiting pattern-based guessing
  • Fix invalid icon tokens in lark-im-card-style.md: mail_colorful → calendar_colorful, approve_colorful → approval_colorful; rewrite guidance to require exact selection from icons.md
  • Fix stale icon token in card-2.0-schema.md example: notice_colorful → lark-logo_colorful

Test Plan

  • make unit-test passed
  • Manual verification: confirmed each icon token in examples matches the exact value listed in resource/icons.md
  • Manual verification: confirmed no invalid/guessed tokens (e.g., mail_colorful, approve_colorful, notice_colorful) remain in card-related docs

Related Issues

  • None

Summary by CodeRabbit

Release Notes

  • Documentation
    • Updated the Card 2.0 root structure JSON example to change header.icon.token from notice_colorful to lark-logo_colorful.
    • Tightened Card 2.0 “Header 图标” guidance: header.icon.token must use the exact colorful tokens from the approved list only; omit icon when no matching token exists.
    • Refreshed quick-scan scenario examples (e.g., mail_colorfulcalendar_colorful) and updated the “发版审批” header icon (approve_colorfulapproval_colorful).
    • Added “彩色图标(精确 token)” reference with a full token mapping table.

@github-actions github-actions Bot added domain/im PR touches the im domain size/M Single-domain feat or fix with limited business impact labels Jul 20, 2026
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 00de64c4-ce83-43a1-b221-a6775c58aac6

📥 Commits

Reviewing files that changed from the base of the PR and between 447e042 and e8e8de7.

📒 Files selected for processing (3)
  • skills/lark-im/references/card/card-2.0-schema.md
  • skills/lark-im/references/card/lark-im-card-style.md
  • skills/lark-im/references/card/resource/icons.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • skills/lark-im/references/card/card-2.0-schema.md
  • skills/lark-im/references/card/resource/icons.md
  • skills/lark-im/references/card/lark-im-card-style.md

📝 Walkthrough

Walkthrough

Card 2.0 documentation now requires exact colorful icon tokens, adds a token reference table, and updates schema and header examples with specific tokens.

Changes

Card icon token references

Layer / File(s) Summary
Exact token rules and catalog
skills/lark-im/references/card/lark-im-card-style.md, skills/lark-im/references/card/resource/icons.md
Icon guidance now requires exact enumerated tokens, documents colorful token values, and states that icon should be omitted when no suitable token exists.
Updated schema and style examples
skills/lark-im/references/card/card-2.0-schema.md, skills/lark-im/references/card/lark-im-card-style.md
Card examples now use lark-logo_colorful, calendar_colorful, and approval_colorful.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague to describe the main change and only names the area affected. Rename it to clearly state the core change, such as adding exact colorful card icon tokens and fixing invalid references.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description matches the template with Summary, Changes, Test Plan, and Related Issues filled in.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@9ecc354cdeb91e6e737765a74132740432dd9236

🧩 Skill update

npx skills add 91-enjoy/cli#feat/card_icon -y -g

@91-enjoy
91-enjoy force-pushed the feat/card_icon branch 2 times, most recently from b4941e8 to 447e042 Compare July 22, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/im PR touches the im domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants