fix(base): classify +form-submit as high-risk-write by yballul-bytedance · Pull Request #1969 · larksuite/cli

yballul-bytedance · 2026-07-20T11:24:48Z

Summary

base +form-submit fills and submits data through a public form share link — an outward-facing, irreversible write. It was classified as write, so it ran without confirmation. This PR reclassifies it as high-risk-write so the runner's --yes confirmation gate fires before execution, consistent with +form-delete and other high-risk base commands.

Changes

shortcuts/base/base_form_submit.go: Risk write → high-risk-write; add baseHighRiskYesTip to Tips. The runner auto-registers --yes and returns confirmation_required (exit 10) when it is missing.
skills/lark-base/references/lark-base-form-submit.md: high-risk warning banner, --yes on all examples, --yes row in the param table, and a tip note.
skills/lark-base/SKILL.md: note +form-submit requires --yes in the high-risk list and form-details section.
Tests: new TestFormSubmitRequiresConfirmation unit test pins the typed confirmation_required gate; existing execute-path tests pass --yes; new tests/cli_e2e/base/base_form_submit_dryrun_test.go dry-run E2E.

Test Plan

Unit tests pass (go test ./shortcuts/base/)
Dry-run E2E passes (go test ./tests/cli_e2e/base/)
gofmt -l, go vet, go mod tidy clean

Related Issues

None

Summary by CodeRabbit

New Features
- Form submissions are now classified as high-risk write operations.
- Added clearer guidance and tips for confirming form submissions.
Bug Fixes
- Form submissions require the --yes confirmation flag before execution.
- Dry-run previews remain available without confirmation.
Documentation
- Updated form submission examples, parameters, warnings, and confirmation requirements.

Form submission writes and submits data through a public share link, an irreversible action that should require explicit confirmation. Reclassify the shortcut from write to high-risk-write so the runner's --yes gate fires before execution, matching +form-delete and other high-risk base commands. Update the lark-base skill docs (--yes on all examples, param table, tips) and add tests pinning the confirmation gate (unit) and dry-run structure (e2e).

coderabbitai · 2026-07-20T11:27:38Z

📝 Walkthrough

Walkthrough

Changes

Form Submit Confirmation

Layer / File(s)	Summary
High-risk shortcut configuration `shortcuts/base/base_form_submit.go`, `shortcuts/base/base_shortcuts_test.go`	`BaseFormSubmit` now uses the `high-risk-write` risk level, includes the confirmation tip, and has an updated risk assertion.
Confirmation and dry-run validation `shortcuts/base/base_shortcuts_test.go`, `tests/cli_e2e/base/base_form_submit_dryrun_test.go`	Tests require `--yes` for write executions, verify the typed confirmation error when omitted, and cover successful dry-run output.
Confirmation guidance `skills/lark-base/SKILL.md`, `skills/lark-base/references/lark-base-form-submit.md`	Guidance and examples document `--yes` for submissions and the exception for `--dry-run`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

base +form-submit lacks a pre-submit human confirmation step (preview before irreversible write) #1545 — Directly covers promoting base +form-submit to a high-risk write requiring --yes.

Possibly related PRs

larksuite/cli#374 — Updates related high-risk confirmation guidance in SKILL.md.
larksuite/cli#759 — Modifies the BaseFormSubmit shortcut.
larksuite/cli#775 — Changes risk-level and confirmation behavior for another write shortcut.

Suggested reviewers: liangshuo-1

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: reclassifying +form-submit as high-risk-write.
Description check	✅ Passed	The description follows the template with Summary, Changes, Test Plan, and Related Issues, and it covers the main changes and verification.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-20T11:30:55Z

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@c352583ab7932211166230214dfc4052b8937b39

🧩 Skill update

npx skills add yballul-bytedance/cli#fix/form-subimit-high-risk -y -g

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/lark-base/references/lark-base-form-submit.md`:
- Line 78: Update the `--yes` entry in the parameter table for the documented
command to state that confirmation is required only for actual execution, while
explicitly exempting `--dry-run`. Keep the existing `confirmation_required`
behavior for high-risk writes without `--yes` and ensure the wording remains
precise and machine-consumable.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 581f5ffc-b845-4fc5-bd1f-d3cf665c401c

📥 Commits

Reviewing files that changed from the base of the PR and between 78390f8 and c352583.

📒 Files selected for processing (5)

shortcuts/base/base_form_submit.go
shortcuts/base/base_shortcuts_test.go
skills/lark-base/SKILL.md
skills/lark-base/references/lark-base-form-submit.md
tests/cli_e2e/base/base_form_submit_dryrun_test.go

coderabbitai · 2026-07-20T11:34:01Z

 | `--share-token <token>` | 是 | 表单分享 Token（必填），从表单分享链接中提取 |
 | `--base-token <token>` | 条件必填 | Base token；**当 `--json` 包含 `attachments` 时必须提供**，用于将附件上传到 Base Drive Media |
 | `--json <json>` | 是 | JSON 对象，包含 `"fields"`（普通字段值）和 `"attachments"`（附件上传），详见下方说明 |
+| `--yes` | 是 | 确认高风险写操作。本命令为 high-risk-write，不带 `--yes` 会返回 `confirmation_required` |


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the --yes requirement conditional for dry-run.

The parameter table says --yes is always required, but this document states that --dry-run does not require it. Update the row to say it is required for execution only, or explicitly document the dry-run exception.

As per coding guidelines, CLI flag documentation must remain precise and machine-consumable.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/lark-base/references/lark-base-form-submit.md` at line 78, Update the `--yes` entry in the parameter table for the documented command to state that confirmation is required only for actual execution, while explicitly exempting `--dry-run`. Keep the existing `confirmation_required` behavior for high-risk writes without `--yes` and ensure the wording remains precise and machine-consumable.

Source: Coding guidelines

zhouyue-bytedance · 2026-07-20T12:14:08Z


 通过表单分享链接填写并提交多维表格表单。仅支持分享模式（share_token），支持填写普通字段值和上传本地文件作为附件。

+> **⚠️ 高风险写操作（high-risk-write）：** 本命令会向表单写入并提交数据，属于高风险写操作，必须额外传递 `--yes` 进行确认，否则会返回 `confirmation_required` 错误并退出。当用户明确要求提交且目标表单无歧义时，直接附加 `--yes`，无需再次询问。


--yes的主要目的是引导agent对风险操作给人确认，我们是否有地方说明什么情况下是要给人确认的。

🤔只要命令是 high-risk，无论是什么情况下都应该让人确认？high-risk 是这个定义

github-actions Bot added domain/base PR touches the base domain size/M Single-domain feat or fix with limited business impact labels Jul 20, 2026

coderabbitai Bot reviewed Jul 20, 2026

View reviewed changes

zhouyue-bytedance reviewed Jul 20, 2026

View reviewed changes

zhouyue-bytedance approved these changes Jul 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(base): classify +form-submit as high-risk-write#1969

fix(base): classify +form-submit as high-risk-write#1969
yballul-bytedance wants to merge 1 commit into
larksuite:mainfrom
yballul-bytedance:fix/form-subimit-high-risk

yballul-bytedance commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 20, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jul 20, 2026

Uh oh!

zhouyue-bytedance Jul 20, 2026

Uh oh!

yballul-bytedance Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		通过表单分享链接填写并提交多维表格表单。仅支持分享模式（share_token），支持填写普通字段值和上传本地文件作为附件。

		> ⚠️ 高风险写操作（high-risk-write）：本命令会向表单写入并提交数据，属于高风险写操作，必须额外传递 `--yes` 进行确认，否则会返回 `confirmation_required` 错误并退出。当用户明确要求提交且目标表单无歧义时，直接附加 `--yes`，无需再次询问。

Uh oh!

Conversation

yballul-bytedance commented Jul 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Test Plan

Related Issues

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 20, 2026

🚀 PR Preview Install Guide

🧰 CLI update

🧩 Skill update

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

zhouyue-bytedance Jul 20, 2026

Choose a reason for hiding this comment

Uh oh!

yballul-bytedance Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yballul-bytedance commented Jul 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 20, 2026 •

edited

Loading