chore: bump lean 4.31 - #175
Open
kejace wants to merge 2 commits into
Open
Conversation
Now that l-adic/CompPoly has a 4.31 branch and l-adic/CompElliptic builds against
it, the dependency chain that capped us at v4.30.0 is unblocked.
- lean-toolchain: v4.30.0 -> v4.31.0
- lakefile.toml: mathlib pin v4.30.0 -> v4.31.0
- vendor/CompElliptic submodule: d6e88aa -> c1f6f90 ("Use l-adic CompPoly for
Lean 4.31"); .gitmodules now tracks l-adic/CompElliptic @ codex/use-l-adic-comppoly
(which requires l-adic/CompPoly @ codex/lean-4.31-cleanup).
- lake-manifest.json: regenerated (mathlib fabf563a, CompPoly via l-adic fork).
Only code breakage was Kimchi/Circuit/VarBaseMul/Ladder.lean: Mathlib 4.31's
`convert (h.mul_left N) using 1` stopped rfl-closing the Int.instDvd vs semigroupDvd
instance subterm, emitting a spurious `Int.instDvd = semigroupDvd` goal. Fixed
instance-safely by rebuilding the divisibility witness through the goal's own
instance (obtain ⟨c,hc⟩ := h; exact ⟨N*c, by linear_combination N*hc⟩) — no convert,
no signature changes.
CompElliptic/CompPoly's Pratt/Lucas primality certificate stays axiom-clean under
4.31 (no native_decide/ofReduceBool). Verified: lake build Kimchi green (8582 jobs);
check-style OK (19 files); axiom gate all 25 roots reduce to
[propext, Classical.choice, Quot.sound, pallas_card, vesta_card].
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forked
CompPoly, updated to4.31, then changed ourCompEllipticto depend on said package.Finally made our repo depend on
CompElliptic @ 4.31Let's see how this builds