-
Notifications
You must be signed in to change notification settings - Fork 2
fix(WhereUI): show splash before the first foreground reveal #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kyleve
wants to merge
3
commits into
main
Choose a base branch
from
codex/consistent-first-foreground-splash
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
Shared/LifecycleKitUI/Sources/LifecycleReadyRevealPolicy.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /// Controls how `LifecycleContainer` presents its first foreground-visible | ||
| /// `.ready` value. | ||
| public enum LifecycleReadyRevealPolicy: Sendable, Hashable { | ||
| /// Let the runner's rendered phases drive presentation. An already-ready | ||
| /// container reveals immediately when no splash appearance established a | ||
| /// minimum-duration hold. | ||
| case phaseDriven | ||
|
|
||
| /// Show the splash before the first visible ready-content reveal, even when | ||
| /// a headless-to-foreground drive completes between SwiftUI render passes. | ||
| /// The splash uses the container's `minimumSplashDuration`. | ||
| case splashBeforeFirstReveal | ||
| } |
54 changes: 54 additions & 0 deletions
54
Shared/LifecycleKitUI/Sources/LifecycleReadyRevealState.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /// The presentation history that decides whether ready content is covered by | ||
| /// the splash. The deadline belongs to a rendered splash appearance—or, for | ||
| /// the opt-in policy, the first visible ready presentation when SwiftUI never | ||
| /// observed the runner's intervening splash phase. | ||
| enum LifecycleReadyRevealState: Equatable { | ||
| case awaitingFirstVisibleReady | ||
| case holdingSplash(until: ContinuousClock.Instant) | ||
| case revealed | ||
|
|
||
| init( | ||
| policy: LifecycleReadyRevealPolicy, | ||
| minimumSplashDuration: Duration, | ||
| ) { | ||
| switch policy { | ||
| case .phaseDriven: | ||
| self = .revealed | ||
| case .splashBeforeFirstReveal: | ||
| self = minimumSplashDuration > .zero ? .awaitingFirstVisibleReady : .revealed | ||
| } | ||
| } | ||
|
|
||
| var canRevealReady: Bool { | ||
| switch self { | ||
| case .awaitingFirstVisibleReady, .holdingSplash: false | ||
| case .revealed: true | ||
| } | ||
| } | ||
|
|
||
| var splashHoldDeadline: ContinuousClock.Instant? { | ||
| switch self { | ||
| case let .holdingSplash(until: deadline): deadline | ||
| case .awaitingFirstVisibleReady, .revealed: nil | ||
| } | ||
| } | ||
|
|
||
| mutating func splashAppeared( | ||
| at instant: ContinuousClock.Instant, | ||
| minimumSplashDuration: Duration, | ||
| ) { | ||
| guard minimumSplashDuration > .zero else { | ||
| self = .revealed | ||
| return | ||
| } | ||
| self = .holdingSplash(until: instant.advanced(by: minimumSplashDuration)) | ||
| } | ||
|
|
||
| mutating func readyBecameVisible( | ||
| at instant: ContinuousClock.Instant, | ||
| minimumSplashDuration: Duration, | ||
| ) { | ||
| guard case .awaitingFirstVisibleReady = self else { return } | ||
| splashAppeared(at: instant, minimumSplashDuration: minimumSplashDuration) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review focus: visibility is deliberately part of this task identity. A background runner can remain
.readybefore and after foreground promotion, so readiness alone would not restart the task that establishes the first visible splash hold.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 9587d79. The hosted regression test now mounts a ready runner headlessly, applies a coalesced foreground-only reason change while the phase stays ready, proves the splash appears and releases, and was mutation-checked to fail if the task identity is reduced to readiness alone.