-
Notifications
You must be signed in to change notification settings - Fork 2
fix(WhereUI): Keep the timeline focused on recent stays #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,8 +73,12 @@ struct YearRibbon: View { | |
| } | ||
| .padding(overview.padding) | ||
| .background { | ||
| RoundedRectangle(cornerRadius: overview.cornerRadius) | ||
| .fill(overview.background) | ||
| ZStack { | ||
| RoundedRectangle(cornerRadius: overview.cornerRadius) | ||
| .fill(.background) | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Review focus: this base fill intentionally makes only the ribbon’s rounded shape opaque. The existing translucent tint remains above it, while the parent inset stays clear so journey content can pass through the corner cutouts without showing through the ribbon itself. |
||
| RoundedRectangle(cornerRadius: overview.cornerRadius) | ||
| .fill(overview.background) | ||
| } | ||
| } | ||
| .overlay { | ||
| RoundedRectangle(cornerRadius: overview.cornerRadius) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review focus: using the
.initialOffsetrole here is deliberate. It starts each newly entered or newly selected year at the latest stint without turning the timeline into a follow-mode that overrides manual scrolling after same-year refreshes.