Add annual location time forecasts by kyleve · Pull Request #187 · kyleve/Stuff

kyleve · 2026-08-05T00:36:16Z

Posted by an AI agent on kve's behalf.

Summary

add current-year location forecasts once three complete months have elapsed
show the three leading location estimates and a focused-calendar estimate
let the user guide the estimate with one synced inclusive planned-stay date
preserve planned-stay revisions through SwiftData, CloudKit conflict resolution, and backup format v3
keep the forecast model independent so future percentage goals can compare against it

Behavior and trade-offs

The baseline annualizes days attributed to a region through today. A matching planned stay counts tomorrow through its inclusive departure date at full weight, then resumes the baseline pace for the remaining year. Only one planned stay is active at a time; clearing or expiry writes a tombstone so delayed sync cannot resurrect it.

Testing

./test --no-generate --everything — 1,638 unit tests and 33 snapshot suites passed
./swiftformat --lint
./xcstrings --lint
ruby -c Where/Tools/upgrade-backup.rb
git diff --check

kyleve · 2026-08-05T00:37:04Z

+            stay.region == region && stay.through >= today ? stay : nil
+        }
+        let plannedEnd = matchingStay.map { min($0.through, lastDay) }
+        let plannedDays = plannedEnd.map { tomorrow.days(through: $0).count } ?? 0


Posted by an AI agent on kve's behalf.

Review focus: this is the load-bearing forecast policy. Planned days begin tomorrow, include the selected through-date, and baseline projection resumes the following day. The tests cover the April threshold, matching and non-matching stays, and cross-year stays.

kyleve · 2026-08-05T23:12:30Z

How come this has the "I'll be here through" button button but others don't? IMO we should have it on all of them?

…orecasts

kyleve · 2026-08-06T02:30:11Z

+
+    public func replacePlannedStayRecord(with record: PlannedStayRecord) async throws {
+        let context = mutationContext()
+        for existing in try context.fetch(FetchDescriptor<SDPlannedStay>()) {


wait, we're fetching them all and deleting them all, for one record?

this feels off

I guess this is because we can only have one planned stay, which wasn't exactly my intent, but maybe it makes sense for now?

kyleve · 2026-08-08T18:50:29Z

+/// User intent that the current stay in `region` continues through an inclusive
+/// calendar day. The day is timezone-independent so travel cannot move the
+/// asserted departure onto a neighboring date.
+public struct PlannedStay: Hashable, Sendable, Codable {


Should we also record when this was added? Might be useful if only for debugging and any UI that may show planned stays, especially if we allow entering future stays at some point.

kyleve · 2026-08-08T18:56:55Z

+final class SDPlannedStay {
+    var id: UUID?
+    var regionID: String?
+    var throughDayKey: String?


Is this how we usually persist CalendarDays?

kyleve · 2026-08-08T19:00:49Z

I think our test data has too many days, if the current date is July 15th, then the stay duration (the regular duration, NOT the stay) should end there too.

kyleve · 2026-08-08T19:03:34Z

@@ -0,0 +1,29 @@
+import SwiftUI


Got to here

…orecasts # Conflicts: # Where/Tools/upgrade-backup.rb # Where/WhereCore/AGENTS.md # Where/WhereCore/README.md # Where/WhereCore/Sources/Backup/BackupArchive.swift # Where/WhereCore/Sources/Backup/BackupCoordinator.swift # Where/WhereCore/Sources/Backup/BackupService.swift # Where/WhereCore/Sources/Persistence/SwiftDataStore.swift # Where/WhereCore/Sources/Preferences/WherePreferences.swift # Where/WhereCore/Tests/BackupCoordinatorTests.swift # Where/WhereCore/Tests/BackupServiceTests.swift # Where/WhereCore/Tests/WherePreferencesTests.swift # Where/WhereUI/AGENTS.md # Where/WhereUI/README.md # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.Empty_iPhone.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.Empty_iPhone_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.Focused_iPhone.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.Focused_iPhone_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.FullContent_fullHeight.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPad.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPad_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPad_ax5.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPad_contrast.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPad_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPhone.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPhone_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPhone_ax5.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPhone_contrast.png # Where/WhereUI/SnapshotTests/__Snapshots__/CalendarContentViewSnapshotTests/calendarContent.WithData_iPhone_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPad.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPad_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPad_ax5.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPad_contrast.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPad_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPhone.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPhone_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPhone_ax5.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPhone_contrast.png # Where/WhereUI/SnapshotTests/__Snapshots__/LocationsViewSnapshotTests/locations.Loaded_iPhone_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Empty_iPhone.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Empty_iPhone_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPad.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPad_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPad_ax5.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPad_contrast.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPad_dark.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPhone.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPhone_accessibility.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPhone_ax5.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPhone_contrast.png # Where/WhereUI/SnapshotTests/__Snapshots__/YearViewSnapshotTests/year.Loaded_iPhone_dark.png # Where/WhereUI/Sources/Model/YearReportModel.swift # Where/WhereUI/Sources/Preview/PreviewSupport.swift # Where/WhereUI/Sources/Primary/CalendarContentView.swift # Where/WhereUI/Sources/Resources/Localizable.xcstrings # Where/WhereUI/Sources/Settings/LocationSettingsView.swift # Where/WhereUI/Sources/Settings/SettingsView.swift # Where/WhereUI/Tests/PrivacyPassportCardTests.swift # Where/WhereUI/Tests/Support/TestStore.swift

Add annual location time forecasts

609559c

kyleve commented Aug 5, 2026

View reviewed changes

kyleve added 7 commits August 4, 2026 17:54

Make planned stay expiry conditional

41c5e4c

Add forecast panel preview

a70174b

Add planned stay editor preview

f0bad2b

Make location forecasts conversational

d841da5

Show elapsed forecast time once

e5b7183

Make location forecasts optional and collapsible

42a03f4

Merge main into location time forecasts

9dd1e8d

kyleve commented Aug 5, 2026

View reviewed changes

kyleve added 13 commits August 5, 2026 16:41

Refine location forecast card chrome

53a1371

Soften location forecast disclosure

74a5951

Merge remote-tracking branch 'origin/main' into codex/location-time-f…

fd8f064

…orecasts

Distinguish planned days in the calendar

5952bf3

Align planned stay hatches across calendar cells

96f2f14

Restore chronological calendar order

4f322b2

Return concurrent planned stay from expiry

16f233b

Keep planned stay revisions monotonic

26a6e20

Show cross-year planned stays in calendar

30a67f1

Keep planned stay previews Gregorian

25ab871

Refresh Gregorian planned stay snapshots

358de6a

Place estimate after current calendar month

42409e5

Add planned stay editor snapshots

14bdd50

kyleve commented Aug 6, 2026

View reviewed changes

Give snapshots solid adaptive backgrounds

bbd986f

kyleve commented Aug 8, 2026

View reviewed changes

Navigation Menu

Add annual location time forecasts - #187

Add annual location time forecasts#187
kyleve wants to merge 23 commits into
mainfrom
codex/location-time-forecasts

kyleve commented Aug 5, 2026

Uh oh!

kyleve Aug 5, 2026

Uh oh!

kyleve Aug 5, 2026

Uh oh!

kyleve Aug 6, 2026

Uh oh!

kyleve Aug 6, 2026

Uh oh!

kyleve Aug 8, 2026

Uh oh!

kyleve Aug 8, 2026

Uh oh!

kyleve Aug 8, 2026

Uh oh!

kyleve Aug 8, 2026

Uh oh!

kyleve Aug 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

kyleve commented Aug 5, 2026

Summary

Behavior and trade-offs

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant