feat: wire snapshot TakeExternalSnapshot to Core endpoint#1
Open
kwonkwonn wants to merge 2 commits into
Open
Conversation
- Fix TakeSnapshotResponse to match Core response shape (uuid, snapKey) - Add CoreClient.TakeExternalSnapshot with 12m timeout for snapshot+upload - Fill in TakeSnapshot TODO: presigned PUT URL -> Core -> RustFS upload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TakeSnapshotResponse를 Core 응답 스펙(uuid,snapKey)에 맞게 수정CoreClient.TakeExternalSnapshot추가 —POST /TakeExternalSnapshot호출, 스냅샷 생성+업로드 소요 시간 고려해 12분 timeout 전용 클라이언트 사용service/external_snap.go:TakeSnapshotTODO 제거 — presigned PUT URL 발급 후 Core에 실제 전달하는 흐름 완성Paired PR
이 PR은 Core 측 구현과 페어로 동작합니다.
Core PR #152: easy-cloud-Knet/KWS_Core#152
Core PR이 머지된 후 Control ↔ Core end-to-end 테스트를 진행하고, 통과 시 본 PR을 머지합니다.
Flow
WIP / Merge Condition
POST /vm/snapshot→ RustFS 버킷 확인)