Skip to content

feat: wire snapshot TakeExternalSnapshot to Core endpoint#1

Open
kwonkwonn wants to merge 2 commits into
mainfrom
feat/snapshot-core-integration
Open

feat: wire snapshot TakeExternalSnapshot to Core endpoint#1
kwonkwonn wants to merge 2 commits into
mainfrom
feat/snapshot-core-integration

Conversation

@kwonkwonn

Copy link
Copy Markdown
Owner

Summary

  • TakeSnapshotResponse 를 Core 응답 스펙(uuid, snapKey)에 맞게 수정
  • CoreClient.TakeExternalSnapshot 추가 — POST /TakeExternalSnapshot 호출, 스냅샷 생성+업로드 소요 시간 고려해 12분 timeout 전용 클라이언트 사용
  • service/external_snap.go:TakeSnapshot TODO 제거 — presigned PUT URL 발급 후 Core에 실제 전달하는 흐름 완성

Paired PR

이 PR은 Core 측 구현과 페어로 동작합니다.

Core PR #152: easy-cloud-Knet/KWS_Core#152

Core PR이 머지된 후 Control ↔ Core end-to-end 테스트를 진행하고, 통과 시 본 PR을 머지합니다.

Flow

POST /vm/snapshot (Control)
  → RustFS: presigned PUT URL 발급
  → Core POST /TakeExternalSnapshot (presignedUrl 전달)
    → Core: 스냅샷 생성 + RustFS 직접 업로드

WIP / Merge Condition

  • Core PR #152 머지 완료
  • Control ↔ Core e2e 테스트 통과 (POST /vm/snapshot → RustFS 버킷 확인)

ga111o and others added 2 commits June 23, 2026 13:09
- Fix TakeSnapshotResponse to match Core response shape (uuid, snapKey)
- Add CoreClient.TakeExternalSnapshot with 12m timeout for snapshot+upload
- Fill in TakeSnapshot TODO: presigned PUT URL -> Core -> RustFS upload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants