Preserve leading minus for RFC 822 zero-hour offsets#162
Closed
santhreal wants to merge 2 commits into
Closed
Conversation
int("-00") is 0, so -00:30 and -0030 were parsed as +00:30.
kurtmckee
approved these changes
Jul 19, 2026
kurtmckee
left a comment
kurtmckee
left a comment
Owner
There was a problem hiding this comment.
Hi @santhreal,
I need to confirm that you're a human before merging, since copyrights and attribution are involved.
Let me know if you're available for a video call. Thanks!
Author
|
No, I prefer to stay anonymous on my GitHub. Sorry about that. I will close this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RFC 822 numeric timezones like
-00:30/-0030were parsed as+00:30becauseint("-00") == 0dropped the sign before applying minutes.Keep the sign, matching the RFC 3339 path.
Test plan
-00:30/-0030