Update for deprecation of kube-dns - #56933
Conversation
kubernetes-prow
Bot
added
language/en
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
lmktfy
left a comment
lmktfy
left a comment
There was a problem hiding this comment.
/lgtm
This change is obviously an improvement on our current docs.
I did spot some nits.
| - --namespace=kube-system | ||
| - --configmap=kube-dns-autoscaler | ||
| # Should keep target in sync with cluster/addons/dns/kube-dns.yaml.base | ||
| # Should keep target in sync with cluster/addons/dns/coredns/coredns.yaml.base |
There was a problem hiding this comment.
Is this right?
Maybe just drop the comment.
There was a problem hiding this comment.
I think what it means is "you, the reader, need to change <SCALE_TARGET> in the next line to coredns, which is the name of the Deployment being scaled, as seen in cluster/addons/dns/coredns/coredns.yaml.base". But I wouldn't swear to that.
There was a problem hiding this comment.
yeah, this seems to have leaked the k/k deployment scripts
| The value for label `k8s-app` for CoreDNS is `kube-dns`, for backward | ||
| compatibility with the original kube-dns. |
There was a problem hiding this comment.
Does CoreDNS, and its recommended ways to deploy it, use the recommended label app.kubernetes.io/name?
If so: we could recommend selecting on app.kubernetes.io/name.
If not: here's an idea for a feature.
There was a problem hiding this comment.
The example deployment has
labels:
k8s-app: kube-dns
kubernetes.io/name: "CoreDNS"
app.kubernetes.io/name: corednsbut the version in k/k has
labels:
k8s-app: kube-dns
kubernetes.io/cluster-service: "true"
addonmanager.kubernetes.io/mode: Reconcile
kubernetes.io/name: "CoreDNS"and FWIW OpenShift's CoreDNS pods have neither.
I'm guessing the recommendations in this file are not actually very portable
kubernetes-prow
Bot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: df3f823a2f5004289e2daab8d95222ad15e3065c |
|
/label tide/merge-method-squash |
kubernetes-prow
Bot
added
the
tide/merge-method-squash
bed9887 to
c55b399
Compare
kubernetes-prow
Bot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/lgtm but it seems there are some formatting issues |
kubernetes-prow
Bot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 43713b91c187fd0494177694d63e67bb37985126 |
where? I didn't notice any... |
4 participants
Part of kubernetes/kubernetes#137556. Not strongly tied to 1.37; could merge either before or after.
There are still many instances of the string
kube-dnsin the docs, mostly because the default CoreDNS install is still called "kube-dns" for backward compatibility. Beyond that:content/en/docs/setup/production-environment/tools/kubeadm/troubleshooting-kubeadm.mdstill says "`coredns` (or `kube-dns`)" in 2 places, since people may still be troubleshooting clusters that use kube-dns.content/en/docs/tasks/administer-cluster/nodelocaldns.mdstill refers to a "kube-dns" ConfigMap, since that's the name it uses.content/en/docs/tasks/administer-cluster/dns-horizontal-autoscaling.md(andcontent/end/examples/admin/dns/dns-horizontal-autoscaler.yaml) still create a "kube-dns-autoscaler", but referencing CoreDNS.content/en/docs/tasks/administer-cluster/dns-custom-nameservers.mdreferences a CoreDNS option that is set "for backward compatibility with `kube-dns`".content/en/docs/reference/access-authn-authz/rbac.mdstill lists the oldkube-dnsRBAC Role, which we continue to create for now./cc @aojea