Skip mapped release-note-none notes - #4474
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SaaiAravindhRaja The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @SaaiAravindhRaja! |
|
Hi @SaaiAravindhRaja. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hi is there anything i can improve on? |
What type of PR is this?
/kind bug
/kind documentation
What this PR does / why we need it:
Fixes release note rendering so PRs marked
release-note-nonestay out of the generated document even when a release notes map exists for the PR. The document builder now skips any note markedDoNotPublish, regardless of whether it was mapped.The tests cover unmapped
release-note-nonenotes, mappedrelease-note-nonenotes, and mapped notes explicitly suppressed withreleasenote.do_not_publish: true. The map documentation also clarifies that merely adding a map does not clear a PR-levelrelease-note-noneexclusion.Which issue(s) this PR fixes:
Fixes #4456
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Testing
go test ./pkg/notes ./pkg/notes/document -run 'TestApplyMap|TestApplyMapPreservesDoNotPublish|TestNew' -count=1go test ./pkg/notes -count=1git diff --name-only origin/master...HEAD -- '*.go' | xargs gofmt -lgit diff --check origin/master...HEADgitleaks detect --no-banner --redact --source . --log-opts origin/master..HEAD