Skip to content

fix: include kubeadm verbosity flag in generated docs - #469

Open
aryansk wants to merge 1 commit into
kubernetes-sigs:masterfrom
aryansk:codex/fix-kubeadm-verbosity-docs
Open

fix: include kubeadm verbosity flag in generated docs#469
aryansk wants to merge 1 commit into
kubernetes-sigs:masterfrom
aryansk:codex/fix-kubeadm-verbosity-docs

Conversation

@aryansk

@aryansk aryansk commented Aug 9, 2026

Copy link
Copy Markdown

Summary

  • initialize kubeadm\u0027s supported klog flags before generating reference docs
  • include -v, --v in generated kubeadm docs while keeping unsupported logging flags hidden

This addresses kubernetes/website#48717.

Validation

  • go test ./...
  • go run main.go build kubeadm
  • verified build/kubeadm.md contains -v, --v int

Codex was used to inspect the issue and repository, implement this focused fix, and run the available validation. I reviewed the final diff and generated output.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 9, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: aryansk / name: Aryan Singh K. (646813e)

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @aryansk!

It looks like this is your first PR to kubernetes-sigs/reference-docs 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/reference-docs has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 9, 2026
@kubernetes-prow kubernetes-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 9, 2026

@neolit123 neolit123 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

$ kubeadm --help

...
 
 -v, --v Level              number for the log level verbosity
      --vmodule moduleSpec   comma-separated list of pattern=N settings for file-filtered logging

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2026
@Caesarsage

Copy link
Copy Markdown
Contributor

you need sign the cla @aryansk so reviewers can review/approve this change

@Caesarsage

Copy link
Copy Markdown
Contributor

/easycla

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 10, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aryansk, lavishpal
Once this PR has been reviewed and has the lgtm label, please assign tengqm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aryansk

aryansk commented Aug 13, 2026

Copy link
Copy Markdown
Author

Thanks @lavishpal for the approval and thoughtful review! Really appreciate you taking the time to look this over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants