fix(gen-apidocs): render ContainerStatus in Pod Markdown reference - #468
fix(gen-apidocs): render ContainerStatus in Pod Markdown reference#468qiujiaro wants to merge 1 commit into
Conversation
|
|
|
Welcome @qiujiaro! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: qiujiaro The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/easycla |
|
Thanks for the PR. changing inline-definition classification can affect other generated API pages. Did you confirm this @qiujiaro ? |
The generated changes are limited to these expected definition restorations #467 (comment) and did not find unrelated changes to other API pages. |
| m.inlinedByParent[home.Key()] = append(m.inlinedByParent[home.Key()], d) | ||
| continue | ||
| } | ||
| if d.IsInlined { |
There was a problem hiding this comment.
can closestTopLevelHome(d) return a valid parent for all d.IsInlined definitions? if not, what cases are expected to have IsInlined == true but no top-level home?
Fixes #467
Related:
Check
closestTopLevelHomebefore skipping pattern-inlined definitions. Thisallows
ContainerStatusto be inlined into the Pod page while preserving theexisting behavior for definitions without a unique top-level owner.
A regression test covering the
ContainerStatus -> PodStatus -> Podreferencechain is included.