added empty databases in target - #1045
Conversation
Signed-off-by: Pulok Saha <puloksaha@appscode.com>
📝 WalkthroughWalkthroughThe MSSQL migration guide now explains how to create empty target databases, recreate them for clean retries, and verify that ChangesMSSQL database migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/guides/mssqlserver/migration/databasemigration.md`:
- Around line 275-283: Update the target-database verification instructions
after the UserTables query to require a result of 0 and explicitly instruct
readers not to continue the migration when UserTables is nonzero.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0195f010-09cf-4562-a7cc-391291a4d734
📒 Files selected for processing (1)
docs/guides/mssqlserver/migration/databasemigration.md
| Verify that the target database has no user tables: | ||
|
|
||
| ```sql | ||
| USE RestaurantMigrationDB; | ||
| GO | ||
|
|
||
| SELECT COUNT(*) AS UserTables FROM sys.tables WHERE is_ms_shipped = 0; | ||
| GO | ||
| ``` |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
State the required verification result.
The query only displays a count. State that UserTables must be 0 and that the migration must not continue when the result is nonzero. Otherwise, a pre-existing or partially migrated RestaurantMigrationDB can be used as the target.
Suggested clarification
SELECT COUNT(*) AS UserTables FROM sys.tables WHERE is_ms_shipped = 0;
GO
+
+The result must be `0`. If it is not `0`, do not apply the migration CR. Delete and recreate the target database, then run this check again.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/guides/mssqlserver/migration/databasemigration.md` around lines 275 -
283, Update the target-database verification instructions after the UserTables
query to require a result of 0 and explicitly instruct readers not to continue
the migration when UserTables is nonzero.
|
Visit the preview URL for this PR (updated for commit 9c214ab): https://kubedb-v2-hugo--pr1045-docs-mssql-migration-yd0h1vlh.web.app (expires Wed, 19 Aug 2026 12:19:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 0f29ae8ae0bd54a99bf2b223b6833be47acd5943 |
Summary by CodeRabbit