Make @kson_org/monaco-editor installable from npm - #407
Open
holodorum wants to merge 2 commits into
Open
Conversation
`@kson/lsp-shared` and `kson-language-server` were declared as runtime `dependencies` via monorepo-relative `file:` paths, but neither package is published and neither path exists outside this repo. The bundler inlines both, so they are build-time only: move them to `devDependencies`, which is what the relationship actually is. Consumers of the published tarball hit this hard — pnpm fails outright with ERR_PNPM_LINKED_PKG_DIR_NOT_FOUND, while npm silently plants a dangling symlink and a damaged lockfile that breaks the next install. The demo installs never caught it because a directory `file:` install resolves the nested `file:` against the real source tree, so only a packed tarball is a faithful proxy for what consumers receive; the new test packs the package and asserts the shipped manifest declares no local-only specifiers.
holodorum
force-pushed
the
fix-monaco-packaging-bug
branch
from
July 16, 2026 14:37
ee235a4 to
19a42c7
Compare
`@kson/lsp-shared` and `kson-language-server` were declared as runtime `dependencies` via monorepo-relative `file:` paths, but neither package is published and neither path exists outside this repo. The bundler inlines both, so they are build-time only: move them to `devDependencies`, which is what the relationship actually is. Consumers of the published tarball hit this hard — pnpm fails outright with ERR_PNPM_LINKED_PKG_DIR_NOT_FOUND, while npm silently plants a dangling symlink and a damaged lockfile that breaks the next install. The demo installs never caught it because a directory `file:` install resolves the nested `file:` against the real source tree, so only a packed tarball is a faithful proxy for what consumers receive; the new test packs the package and asserts the shipped manifest declares no local-only specifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kson/lsp-sharedandkson-language-serverwere declared as runtimedependenciesvia monorepo-relativefile:paths, but neither package is published and neither path exists outside this repo. The bundler inlines both, so they are build-time only: move them todevDependencies, which is what the relationship actually is. Consumers of the published tarball hit this hard — pnpm fails outright withERR_PNPM_LINKED_PKG_DIR_NOT_FOUND, while npm silently plants a dangling symlink and a damaged lockfile that breaks the next install.The demo installs never caught it because a directory
file:install resolves the nestedfile:against the real source tree, so only a packed tarball is a faithful proxy for what consumers receive; the new test packs the package and asserts the shipped manifest declares no local-only specifiers.