fix: doctor/preflight の core.hooksPath 読取に --includes (#196 smoke 発見) - #198
Merged
Conversation
配線値は include 先の hooks.gitconfig にあり、`git config --global --get` は scope file 指定時に include を既定で展開しない → 正しく配線済みのマシンを 「not set」と誤報告していた (配線自体は実効・git 本体は読み時に include 処理)。 3 call site に --includes を付け、観測形そのものを static pin する回帰テストを 追加。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016qw8BkUDu5WdwhYfiFFX5n
Owner
Author
🔍 レビュー依頼(→ Codex)
|
Owner
Author
📋 レビュー結果(by Codex)判定: ✅ merge 可(must 0 件) — should / nit ともなし。 Codex の独立確認: CI green を確認して merge します。 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
#196 の実機 smoke で発見した観測バグの修正。配線自体は実効(git 本体は読み時に include を処理し、repo 内で
core.hooksPathが解決される)だが、doctor / preflight の読取git config --global --get core.hooksPathが scope file 指定時は include を既定で展開しない ため、正しく配線済みのマシンを「not set」と誤報告していた(report-only の warn ノイズ + 配線 chain の偽の非緑)。変更
--includesを付与 + 理由コメント--includes付き読取の存在 + includes 無し読取の不在)。観測側の読取形そのものが契約なので static pin が適切検証
🤖 Generated with Claude Code
https://claude.ai/code/session_016qw8BkUDu5WdwhYfiFFX5n