feat(doctor): agent-tools status contract v3 に追従 (Closes #194) - #195
Merged
Conversation
agent-tools#186 (#198, bb085a9) で status contract が v2→v3 になった (target state に deployed_but_inactive を追加 = 未登録なのに実体が残る 配置物の可視化)。doctor の expected version を 3 へ更新し (exact-match 維持・fail-closed のまま)、conflict / stale と同様に deployed_but_inactive の件数 warn を追加する (掃除候補の可視化という新語彙の趣旨に沿う消費)。 test-doctor: fake status.sh fixture を v3 化し、deployed_but_inactive target を足して新 warn の発火を検証。unknown version ケースは "expected 3" に追従。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wqz3c5ope2oVauyyWZNkyv
Owner
Author
🔍 レビュー依頼(→ Codex)
|
- test-doctor: unknown contract version の fixture に sentinel fields (repo / sync_targets) を持たせ、warn を出しつつ fields を解釈する退行を 否定検証で固定 (working tree / sync conflicts / deployed-but-inactive の summary 行が出ないこと)。 - docs/ai-environment-boundary.md: contract_version 2 の残存記載を 3 へ更新し deployed_but_inactive を warning 対象に追記。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wqz3c5ope2oVauyyWZNkyv
Owner
Author
📋 レビュー結果(by Codex / gpt-5.6-sol・reasoning=medium)判定: ✅ merge 可(must 0 件) — 🟡 should 2 件は両方採用し 🟡 should (採用・対応済み)
Codex の確認内容
補足 (依頼元)
must 0 のため merge 可。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Closes #194。agent-tools#186 (kosako/agent-tools#198,
bb085a9) で status contract が v2→v3 になった (target state にdeployed_but_inactiveを追加 = 「一度承認して配布 → 後で gate がかかった」まま実体がディスクに残る配置物の可視化)。変更内容
scripts/doctor.sh: expected contract_version を 3 へ更新 (exact-match 維持 = 未知 version は従来どおり「not interpreting fields」の fail-closed warn)。conflict / stale と同様にdeployed_but_inactiveの件数 warn を追加 (掃除候補の可視化という新語彙の趣旨に沿う消費)。scripts/test-doctor.sh: fake status.sh fixture を v3 化し、deployed_but_inactivetarget を追加して新 warn の発火を検証。unknown-version ケースの期待文言を "expected 3" に追従。AGENT_TOOLS override ケースの fixture / 期待文言も v3 化。検証
scripts/test-doctor.shfull run 緑 (exit 0・全 [ok])。author=Claude → reviewer=Codex (相互レビュー契約)。
🤖 Generated with Claude Code
https://claude.ai/code/session_01Wqz3c5ope2oVauyyWZNkyv