Skip to content

fix: modernize review executor and verdict semantics - #220

Merged
kosako merged 5 commits into
mainfrom
codex/issue-214-review-executor-verdict
Jul 15, 2026
Merged

fix: modernize review executor and verdict semantics#220
kosako merged 5 commits into
mainfrom
codex/issue-214-review-executor-verdict

Conversation

@kosako

@kosako kosako commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • make personal-codex-review a capability-checked, ephemeral read-only executor using native review --base/--commit/--uncommitted modes
  • fail closed on author/routing, CLI capability, target OID, invalid ref/option boundaries, or clean-worktree mismatches without mutating the checkout
  • keep GitHub lifecycle and draft-before-diff authorization in personal-review-request
  • move severity/verdict/independence semantics into a self-owned output contract
  • add positive and adversarial eval specs, including mixed/unknown authors, wrong PR targets, invalid refs, and unique stacked eval IDs

Closes #214

Independent review

  • Routing preflight: all five commits are authored by Codex, so the required reviewer is Claude.
  • Restacked Fable review (4f91e2a..d2a3999): must 0 / should 1 / nit 3, verdict WARNING.
  • First fix/re-review (4f91e2a..b13eb9f): earlier four findings RESOLVED; must 0 / should 1 / nit 2, verdict WARNING.
  • Final cumulative Fable re-review (4f91e2a..50dc8e6): all seven prior findings RESOLVED; must 0 / should 0 / nit 1, verdict APPROVE.
  • Remaining nit is optional wording alignment in one adversarial eval; it does not weaken the fail-closed behavior.

Validation

  • all 17 scripts/tests/*.sh self-tests
  • scripts/check-manifests.sh — 21 manifests passed
  • scripts/check-injection.sh — only expected pre-existing findings in unrelated assets
  • scripts/build.sh — 42 artifacts built
  • scripts/register.sh — 42 registered, pending 0
  • current Codex CLI accepts native review modes, stdin prompt, read-only sandbox, config override, ephemeral mode, --base=<ref>, and --commit=<oid>
  • Git ref validation and rev-parse --end-of-options behavior checked
  • eval IDs checked unique across changed eval files
  • staged public-safety gate passed

kosako and others added 3 commits July 16, 2026 01:12
Refs #214

Co-Authored-By: Codex <noreply@openai.com>
Refs #214

Co-Authored-By: Codex <noreply@openai.com>
Refs #214

Co-Authored-By: Codex <noreply@openai.com>
@kosako
kosako force-pushed the codex/issue-214-review-executor-verdict branch from 91ec0c2 to d2a3999 Compare July 15, 2026 16:14
@kosako
kosako changed the base branch from codex/issue-212-review-authorization to main July 15, 2026 16:14
kosako and others added 2 commits July 16, 2026 01:22
Refs #214

Co-Authored-By: Codex <noreply@openai.com>
Refs #214

Co-Authored-By: Codex <noreply@openai.com>
@kosako
kosako marked this pull request as ready for review July 15, 2026 16:31
@kosako
kosako merged commit 41b7e7b into main Jul 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modernize review executor and separate verdict semantics

1 participant