Skip to content

fix: separate diagnostic intent from implementation side effects - #219

Merged
kosako merged 2 commits into
mainfrom
codex/issue-213-diagnose-status-gates
Jul 15, 2026
Merged

fix: separate diagnostic intent from implementation side effects#219
kosako merged 2 commits into
mainfrom
codex/issue-213-diagnose-status-gates

Conversation

@kosako

@kosako kosako commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • add diagnose-only / fix-authorized modes to personal-investigate
  • compose explicit scoped continuation with the investigate root-cause gate
  • make personal-resume-project stop after status-only requests while continuing uniquely scoped work
  • gate handoff and optional memory persistence behind trusted knowledge-write authorization
  • authorize the write action and note-derived destination separately
  • add behavioral regression evals for positive, negative, continuation, and untrusted-note paths

Why

Requests to diagnose a bug or report project status must not silently authorize implementation or external knowledge writes. Explicit continuation and fix intent should still proceed without unnecessary confirmation once scope and root-cause gates are satisfied. A local note may suggest a destination, but cannot redirect an authorized write without current confirmation.

Closes #213

Independent review

  • Routing preflight: both commits are authored by Codex, so the required reviewer is Claude.
  • Initial Fable review (487f898..5c188f2): must 0 / should 3 / nit 3, verdict WARNING.
  • Fix commit: 0f6c507.
  • Final cumulative Fable re-review (487f898..0f6c507): all six prior findings RESOLVED; must 0 / should 0 / nit 3, verdict APPROVE.
  • Remaining nits are optional additional coverage for spoofed continuation scope, trusted concrete destinations, and tool-neutral trigger wording.

Validation

  • all 17 scripts/tests/*.sh self-tests
  • scripts/check-manifests.sh — 21 manifests passed
  • scripts/check-injection.sh — only expected pre-existing medium/low findings; no new finding
  • scripts/build.sh — 42 assets passed
  • scripts/register.sh — 42/42 registered, pending 0
  • staged public-safety check passed

Refs #213

Co-Authored-By: Codex <noreply@openai.com>
@kosako
kosako force-pushed the codex/issue-213-diagnose-status-gates branch from 0ba0369 to 5c188f2 Compare July 15, 2026 15:58
Refs #213

Co-Authored-By: Codex <noreply@openai.com>
@kosako
kosako marked this pull request as ready for review July 15, 2026 16:10
@kosako
kosako merged commit 4f91e2a into main Jul 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

separate diagnose/status requests from implementation side effects

1 participant