server: inbox / login の HTML 生成を inbox-view.js へ切り出す (#109 R-2) - #113
Merged
Conversation
挙動を変えないリファクタリング(Issue #109 スライス R-2)。HTML 出力は バイト単位で不変(inbox の data 属性・削除ボタン等を pin する既存テストは 無変更で pass)。 - renderInbox / renderImportPanel / renderFilterPanel / renderGitHubCell / renderScreenshotPreview / formatSlackStatus / feedbackStatusOf / renderLoginPage を server/inbox-view.js(CJS)へ verbatim move - inbox-view.js は shared/format.js と store.js の FEEDBACK_STATUSES を 直接 require し、receiver の設定・状態に依存するもの(screenshotUrlFor / formatScreenshotStatus / safeLinkUrl / GITHUB_CONFIGURED 等)は createInboxView(deps) factory で注入 - responder(handleGetInbox / respondLoginPage 等)と Slack / GitHub 整形と 共有するヘルパは receive.js に残置 実装: Codex(Claude 作成のブリーフに基づく)。検証: npm run check 全 113 テスト pass。 Co-Authored-By: Codex <noreply@openai.com>
inbox-view は screenshot.url を safeLinkUrl で直接検証しており screenshotUrlFor を読まない(Claude レビュー 🟡)。 Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
#111 の再作成(#110 の squash merge で base ブランチが消えた際に GitHub が #111 を自動 close し、base 消失のため reopen 不可だった。内容は #111 と同一で、main へ rebase 済み)。
#109 のスライス R-2。挙動を一切変えないリファクタリング。詳細・レビュー履歴は #111 を参照:
server/inbox-view.js(CJS、createInboxView factory)へ verbatim move。receive.js: 2094 → 1874 行実装: Codex / レビュー: Claude(相互レビュー契約)
🤖 Generated with Claude Code
https://claude.ai/code/session_01LRdDjwxbAAaTMwwnzipkau