Skip to content

fix(ie/pps): accept 'B' as second letter (2024 rule)#160

Merged
koblas merged 1 commit into
koblas:mainfrom
spokodev:fix/ie-pps-second-letter-b
Jul 8, 2026
Merged

fix(ie/pps): accept 'B' as second letter (2024 rule)#160
koblas merged 1 commit into
koblas:mainfrom
spokodev:fix/ie-pps-second-letter-b

Conversation

@spokodev

@spokodev spokodev commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Ireland began issuing PPS numbers with B as the second letter on all new numbers as of 2024. The syntax regex omits B and the 2013-format check-digit branch only recognises A/H, so a valid number such as 1234567OB is rejected with InvalidFormat.

Align the regex ([ABHWTX]?) and the check-digit branch (ABH) with the current rule, matching the upstream python-stdnum reference (validate('1234567OB')'1234567OB').

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the Irish PPS number validation logic to support new formats introduced in 2024. By adjusting the regular expression and the check-digit validation branch, the library now correctly recognizes numbers containing 'B' as the second letter, ensuring compliance with current standards and parity with upstream implementations.

Highlights

  • Regex Update: Updated the PPS number validation regex to include 'B' as a valid second letter, aligning with 2024 regulatory changes.
  • Check-Digit Logic: Modified the check-digit validation logic to correctly process numbers containing 'B' in the second-to-last position.
  • Test Coverage: Added a new test case to verify that PPS numbers with 'B' as the second letter are correctly validated.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Irish PPS number validator to support 'B' as a valid second letter, reflecting changes introduced in 2024. The updates include modifying the JSDoc documentation, updating the regular expression pattern, and adjusting the check digit validation logic to include 'B'. Additionally, a new unit test has been added to verify this functionality. There are no review comments, so no feedback is provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@koblas koblas merged commit b92f4b3 into koblas:main Jul 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants