fix(ie/pps): accept 'B' as second letter (2024 rule)#160
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Irish PPS number validation logic to support new formats introduced in 2024. By adjusting the regular expression and the check-digit validation branch, the library now correctly recognizes numbers containing 'B' as the second letter, ensuring compliance with current standards and parity with upstream implementations. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Irish PPS number validator to support 'B' as a valid second letter, reflecting changes introduced in 2024. The updates include modifying the JSDoc documentation, updating the regular expression pattern, and adjusting the check digit validation logic to include 'B'. Additionally, a new unit test has been added to verify this functionality. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Ireland began issuing PPS numbers with
Bas the second letter on all new numbers as of 2024. The syntax regex omitsBand the 2013-format check-digit branch only recognisesA/H, so a valid number such as1234567OBis rejected withInvalidFormat.Align the regex (
[ABHWTX]?) and the check-digit branch (ABH) with the current rule, matching the upstream python-stdnum reference (validate('1234567OB')→'1234567OB').