fix: handle missing features in feed settings response#1025
Open
abdtriedcoding wants to merge 1 commit into
Open
fix: handle missing features in feed settings response#1025abdtriedcoding wants to merge 1 commit into
abdtriedcoding wants to merge 1 commit into
Conversation
Normalize feed settings when the API returns a partial body (e.g. on flaky networks) and guard branding_required access in NotificationFeed components. Fixes knocklabs#1018 Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 089e177 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@abdtriedcoding is attempting to deploy a commit to the Knock Team on Vercel. A member of the Team first needs to authorize it. |
cjbell
approved these changes
Jul 7, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 63.95% 63.97% +0.02%
==========================================
Files 212 212
Lines 10028 10034 +6
Branches 1321 1322 +1
==========================================
+ Hits 6413 6419 +6
Misses 3590 3590
Partials 25 25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1018
Users on flaky networks can receive a successful (200) response from the feed settings endpoint with a partial or empty body (e.g. missing the
featuresobject). The SDK then crashed with:TypeError: can't access property "branding_required", v.features is undefinedThis PR:
useFeedSettingssofeatures.branding_requiredalways defaults safely when missingfeaturesin both web and React NativeNotificationFeedcomponentsTodos
None.
Checklist
Test plan
yarn test—useFeedSettingstests pass (including new partial response case)yarn workspace @knocklabs/react-core type:checkpassesyarn workspace @knocklabs/react-core lintpassesyarn workspace @knocklabs/react lintpassesyarn workspace @knocklabs/react-native lintpasses