Draft PR for Diff#7
Draft
kldjonge wants to merge 22 commits into
Draft
Conversation
The CONTAM-like implementation resulted in dp_turbulent values that are too low, effectively resulting in issues when dpAB switches direction in the door model.
This reverts commit f1f7250.
Minimum dp_turbulent to guard for it becoming a very small value. 10e-10 is chosen as it alligns with CONTAM.
Use doordiscretized in stead of doordiscretizedoperable of not operable. This is more efficient because it uses the more efficiënt powerlawfixedM function in the background.
Minimum dp_turbulent to guard for it becoming a very small value. 10e-10 is chosen as it alligns with CONTAM.
…IDEAS into HeriTace_twoportrobust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.