Skip to content

fix: preserve all rendering proxy evaluate scripts#1659

Merged
kitsuyui merged 1 commit into
mainfrom
fix/audit-implicit-behavior-audit-004
Jul 18, 2026
Merged

fix: preserve all rendering proxy evaluate scripts#1659
kitsuyui merged 1 commit into
mainfrom
fix/audit-implicit-behavior-audit-004

Conversation

@kitsuyui

@kitsuyui kitsuyui commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve all evaluates entries from the X-Rendering-Proxy request header
  • remove the server-only silent truncation that dropped scripts after the first 10 entries
  • update the header parsing regression test to cover unbounded passthrough

Why

Server mode exposed evaluates as a plain string[], but the request parser silently discarded entries after the first 10. That made later scripts disappear without an error even though the programmatic API and README describe the field as a normal string array.

Testing

  • bun run lint
  • bun run typecheck
  • bun run test

Avoid truncating X-Rendering-Proxy evaluates entries so every requested script reaches the renderer.
@github-actions

Copy link
Copy Markdown

gh-counter

PR gate

Removed Added +/-
TODO/expect-error 0 0 0

Repo dashboard

main (6aabcd3) #1659 (21f462a) +/-
TODO/expect-error 4 4 0

Reported by gh-counter

@github-actions

Copy link
Copy Markdown

Code Metrics Report

main (6aabcd3) #1659 (21f462a) +/-
Coverage 84.3% 84.2% -0.1%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Test Execution Time 11s 11s 0s
Details
  |                     | main (6aabcd3) | #1659 (21f462a) |  +/-  |
  |---------------------|----------------|-----------------|-------|
- | Coverage            |          84.3% |           84.2% | -0.1% |
  |   Files             |             11 |              11 |     0 |
  |   Lines             |            243 |             242 |    -1 |
- |   Covered           |            205 |             204 |    -1 |
+ | Code to Test Ratio  |          1:0.5 |           1:0.5 |  +0.0 |
  |   Code              |           1886 |            1885 |    -1 |
  |   Test              |           1072 |            1072 |     0 |
  | Test Execution Time |            11s |             11s |    0s |

Code coverage of files in pull request scope (95.6% → 95.4%)

Files Coverage +/- Status
src/server/request_options.ts 95.4% -0.2% modified

Reported by octocov

@kitsuyui
kitsuyui merged commit 849befa into main Jul 18, 2026
10 checks passed
@kitsuyui
kitsuyui deleted the fix/audit-implicit-behavior-audit-004 branch July 18, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant